Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2921713002: Reland "Send FrameSwapMessageQueue's messages in QueueMessageSwapPromise" with fixes (Closed)

Created:
3 years, 6 months ago by Saman Sami
Modified:
3 years, 6 months ago
Reviewers:
Fady Samuel, boliu, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Send FrameSwapMessageQueue's messages in QueueMessageSwapPromise" with fixes This CL relands crrev.com/2899073006 with some fixes/tweaks: - RWHI::DidProcessFrame is not currently called in the SynchronousCompositor code path. RWHVAndroid::SynchronousFrameMetadata should call into RWHI::DidProcessFrame. - SynchronousCFS::SubmitCompositorFrame will not send the frame to the browser after fallback tick fires. We should make sure QueueMessageSwapPromise doesn't send the swap messages either. - There is no reason to pass frame_swap_message_queue to RendererCFS. BUG=726485 Review-Url: https://codereview.chromium.org/2921713002 Cr-Commit-Position: refs/heads/master@{#476457} Committed: https://chromium.googlesource.com/chromium/src/+/26510e44586a955a51499aec887aceca6ba06a4f

Patch Set 1 #

Patch Set 2 : Don't pass to RCFS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -59 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/android/synchronous_compositor_frame_sink.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/gpu/frame_swap_message_queue.h View 4 chunks +10 lines, -1 line 0 comments Download
M content/renderer/gpu/frame_swap_message_queue.cc View 2 chunks +15 lines, -2 lines 0 comments Download
M content/renderer/gpu/frame_swap_message_queue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/queue_message_swap_promise.cc View 2 chunks +17 lines, -1 line 0 comments Download
M content/renderer/gpu/queue_message_swap_promise_unittest.cc View 12 chunks +42 lines, -14 lines 0 comments Download
M content/renderer/gpu/renderer_compositor_frame_sink.h View 1 3 chunks +2 lines, -6 lines 0 comments Download
M content/renderer/gpu/renderer_compositor_frame_sink.cc View 1 6 chunks +2 lines, -25 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (15 generated)
Saman Sami
3 years, 6 months ago (2017-06-01 20:01:10 UTC) #10
Saman Sami
boliu please review android
3 years, 6 months ago (2017-06-01 20:09:33 UTC) #12
boliu
lgtm
3 years, 6 months ago (2017-06-01 21:41:29 UTC) #13
Fady Samuel
lgtm
3 years, 6 months ago (2017-06-01 21:43:04 UTC) #14
Saman Sami
piman please review content
3 years, 6 months ago (2017-06-01 21:49:01 UTC) #16
piman
lgtm
3 years, 6 months ago (2017-06-01 22:01:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921713002/20001
3 years, 6 months ago (2017-06-01 22:23:45 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 22:29:49 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/26510e44586a955a51499aec887a...

Powered by Google App Engine
This is Rietveld 408576698