Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2921663004: Add Style team members to style directory OWNERS files. (Closed)

Created:
3 years, 6 months ago by meade_UTC10
Modified:
3 years, 5 months ago
CC:
abarth-chromium, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rwlbuis, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Style team members to style directory OWNERS files. This allows us to more equitably spread reviews among the team. This is similar to what the Paint and Layout team does. Review-Url: https://codereview.chromium.org/2921663004 Cr-Commit-Position: refs/heads/master@{#483943} Committed: https://chromium.googlesource.com/chromium/src/+/09f09976f9f327e256d663014164d50bb9e6a719

Patch Set 1 #

Patch Set 2 : add comments #

Total comments: 2

Patch Set 3 : Remove comments, too hard #

Patch Set 4 : Tweak #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M third_party/WebKit/Source/core/animation/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/OWNERS View 1 2 4 5 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/OWNERS View 1 2 5 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
shend
https://codereview.chromium.org/2921663004/diff/20001/third_party/WebKit/Source/core/style/OWNERS File third_party/WebKit/Source/core/style/OWNERS (right): https://codereview.chromium.org/2921663004/diff/20001/third_party/WebKit/Source/core/style/OWNERS#newcode6 third_party/WebKit/Source/core/style/OWNERS:6: shend@chromium.org # Primary experties: ComputedStyle and friends expertise :)
3 years, 6 months ago (2017-06-02 04:49:38 UTC) #2
Bugs Nash
https://codereview.chromium.org/2921663004/diff/20001/third_party/WebKit/Source/core/style/OWNERS File third_party/WebKit/Source/core/style/OWNERS (right): https://codereview.chromium.org/2921663004/diff/20001/third_party/WebKit/Source/core/style/OWNERS#newcode2 third_party/WebKit/Source/core/style/OWNERS:2: bugsnash@chromium.org # Primary expertise: parser primary expertise also properties ...
3 years, 6 months ago (2017-06-08 05:48:46 UTC) #5
meade_UTC10
3 years, 6 months ago (2017-06-14 05:14:29 UTC) #8
Eric Willigers
lgtm
3 years, 6 months ago (2017-06-14 22:42:26 UTC) #9
rjwright
lgtm
3 years, 6 months ago (2017-06-15 03:27:44 UTC) #10
alancutter (OOO until 2018)
I would like to see a team discussion and a rationale doc before going ahead ...
3 years, 6 months ago (2017-06-15 04:48:46 UTC) #11
alancutter (OOO until 2018)
lgtm after below is addressed. If we can also point to layout/paint team as something ...
3 years, 5 months ago (2017-06-29 07:16:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921663004/100001
3 years, 5 months ago (2017-07-03 03:38:59 UTC) #17
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 05:19:58 UTC) #20
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/09f09976f9f327e256d663014164...

Powered by Google App Engine
This is Rietveld 408576698