Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2921663003: GRC: Hook up process-level CoordinationUnits in the browser process (Closed)

Created:
3 years, 6 months ago by oystein (OOO til 10th of July)
Modified:
3 years, 6 months ago
Reviewers:
nasko
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

GRC: Hook up process-level CoordinationUnits in the browser process It's created on demand, and currently won't be instantiated without the GlobalResourceCoordinator feature flag. An example of full GRC usage can be seen in https://codereview.chromium.org/2710823003 This CL depends on https://codereview.chromium.org/2913253002 R=nasko@chromium.org BUG=691886 Review-Url: https://codereview.chromium.org/2921663003 Cr-Commit-Position: refs/heads/master@{#477217} Committed: https://chromium.googlesource.com/chromium/src/+/2ba96b06da25d3e9e905a3a6d2c22f347ecdc9fe

Patch Set 1 #

Patch Set 2 : Tests buildfix #

Patch Set 3 : Review fixes #

Patch Set 4 : Buildfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download
M content/public/browser/render_process_host.h View 2 chunks +8 lines, -0 lines 0 comments Download
M content/public/test/mock_render_process_host.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (12 generated)
oystein (OOO til 10th of July)
nasko: ptal :). Similar thing to https://codereview.chromium.org/2913253002
3 years, 6 months ago (2017-06-01 21:06:10 UTC) #6
nasko
Can we add to this CL the code that uses it outside of content? The ...
3 years, 6 months ago (2017-06-03 00:26:52 UTC) #10
oystein (OOO til 10th of July)
On 2017/06/03 at 00:26:52, nasko wrote: > Can we add to this CL the code ...
3 years, 6 months ago (2017-06-05 20:08:17 UTC) #11
nasko
LGTM
3 years, 6 months ago (2017-06-05 23:59:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921663003/60001
3 years, 6 months ago (2017-06-06 04:09:17 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 06:44:02 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2ba96b06da25d3e9e905a3a6d2c2...

Powered by Google App Engine
This is Rietveld 408576698