cros: Remove get user info code from OAuth2LoginManager

cros: Remove get user info code from OAuth2LoginManager

- Remove get user info code since it does not actually work.
  The missing account info should be fixed on the root cause
  instead of band-aid it in OAuth2LoginManager;
- Use std::string instead of std::string& for primary account id;

BUG=728683
Review-Url: https://codereview.chromium.org/2921653004
Cr-Commit-Position: refs/heads/master@{#479714}
Committed: https://chromium.googlesource.com/chromium/src/+/b674b355a83fe5d12a0dd883818aaebdd35006bd

[xiyuan, 2017-06-01 23:15:21]

Description was changed from

==========
cros: Work around user profile not properly initialized

There is an unknown cause that loads the user profile without
going through UserSessionManager. This causes the user profile
not properly initialized, e.g. authenticated account id is not
set for the SigninManager PKS. The CL works around the problem
by ensuring InitProfilePreferences is called. The CL can be
reverted once we figure out where is the code that loads user
profile prematurely.

BUG=728683
==========

to

==========
cros: Work around user profile not properly initialized

There is an unknown cause that loads the user profile without
going through UserSessionManager. This causes the user profile
not properly initialized, e.g. authenticated account id is not
set for the SigninManager PKS. The CL works around the problem
by ensuring InitProfilePreferences is called. The CL can be
reverted once we figure out where is the code that loads user
profile prematurely.

Also include OAuth2LoginManager clean up that removes the user
account info fetching since it does not work and we should fix
the source of missing primary account id instead.

BUG=728683
==========

[xiyuan, 2017-06-01 23:15:26]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 23:16:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 00:40:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 00:40:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2017-06-14 19:56:17]

Description was changed from

==========
cros: Work around user profile not properly initialized

There is an unknown cause that loads the user profile without
going through UserSessionManager. This causes the user profile
not properly initialized, e.g. authenticated account id is not
set for the SigninManager PKS. The CL works around the problem
by ensuring InitProfilePreferences is called. The CL can be
reverted once we figure out where is the code that loads user
profile prematurely.

Also include OAuth2LoginManager clean up that removes the user
account info fetching since it does not work and we should fix
the source of missing primary account id instead.

BUG=728683
==========

to

==========
cros: Remove get user info code from OAuth2LoginManager

- Remove get user info code since it does not actually work.
  The missing account info should be fixed on the root cause
  instead of band-aid it in OAuth2LoginManager;
- Use std::string instead of std::string& for primary account id;

BUG=728683
==========

[xiyuan, 2017-06-14 19:56:21]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[xiyuan, 2017-06-14 19:56:38]

xiyuan@chromium.org changed reviewers:
+ khmel@chromium.org

[xiyuan, 2017-06-14 19:56:39]

The clean-up that we discussed.

[commit-bot: I haz the power, 2017-06-14 19:56:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 20:31:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 20:31:21]

Dry run: This issue passed the CQ dry run.

[khmel, 2017-06-15 15:23:37]

Nice!

lgtm

[xiyuan, 2017-06-15 15:38:04]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2017-06-15 15:38:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 15:43:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497541084407670,
"parent_rev": "527670475d874c4d8f69e74775812ab948e05567", "commit_rev":
"b674b355a83fe5d12a0dd883818aaebdd35006bd"}

[commit-bot: I haz the power, 2017-06-15 15:43:19]

Description was changed from

==========
cros: Remove get user info code from OAuth2LoginManager

- Remove get user info code since it does not actually work.
  The missing account info should be fixed on the root cause
  instead of band-aid it in OAuth2LoginManager;
- Use std::string instead of std::string& for primary account id;

BUG=728683
==========

to

==========
cros: Remove get user info code from OAuth2LoginManager

- Remove get user info code since it does not actually work.
  The missing account info should be fixed on the root cause
  instead of band-aid it in OAuth2LoginManager;
- Use std::string instead of std::string& for primary account id;

BUG=728683

Review-Url: https://codereview.chromium.org/2921653004
Cr-Commit-Position: refs/heads/master@{#479714}
Committed:
https://chromium.googlesource.com/chromium/src/+/b674b355a83fe5d12a0dd883818a...
==========

[commit-bot: I haz the power, 2017-06-15 15:43:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b674b355a83fe5d12a0dd883818a...