Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 2921623005: Take #2 at suppressing TSAN race from TimerSequenceTest (Closed)

Created:
3 years, 6 months ago by gab
Modified:
3 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Take #2 at suppressing TSAN race from TimerSequenceTest Same goal as https://codereview.chromium.org/2921463003 I think that one didn't suppress properly because the TestBody itself isn't in the racy stacks (merely in the spawning stacks which might not count in the suppression rules)... Unsuppressed race report @ https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_TSan_Tests%2F6818%2F%2B%2Frecipes%2Fsteps%2Fbase_unittests%2F0%2Flogs%2FTimerSequenceTest.OneShotTimerUsedAndTaskedOnDifferentPools%2F0 BUG=552633 TBR=danakj@chromium.org NOTRY=True Review-Url: https://codereview.chromium.org/2921623005 Cr-Commit-Position: refs/heads/master@{#476400} Committed: https://chromium.googlesource.com/chromium/src/+/f6d250552b949fadd00a4ddb42063e93411df272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
gab
TBR dana, attempt #2...
3 years, 6 months ago (2017-06-01 19:48:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921623005/1
3 years, 6 months ago (2017-06-01 19:49:55 UTC) #6
danakj
LGTM
3 years, 6 months ago (2017-06-01 19:49:56 UTC) #7
danakj
Can you make the CL description have a bit more context
3 years, 6 months ago (2017-06-01 19:50:09 UTC) #8
danakj
On 2017/06/01 19:50:09, danakj wrote: > Can you make the CL description have a bit ...
3 years, 6 months ago (2017-06-01 19:50:17 UTC) #9
gab
On 2017/06/01 19:50:17, danakj wrote: > On 2017/06/01 19:50:09, danakj wrote: > > Can you ...
3 years, 6 months ago (2017-06-01 19:54:36 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 20:03:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f6d250552b949fadd00a4ddb4206...

Powered by Google App Engine
This is Rietveld 408576698