Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2993)

Unified Diff: chrome/browser/android/webapk/webapk_installer.h

Issue 2921623004: Support badge icon in WebAPK update components (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_installer.h
diff --git a/chrome/browser/android/webapk/webapk_installer.h b/chrome/browser/android/webapk/webapk_installer.h
index 896935f2b7b68585b5aa62cb40c352bcd0e0cb42..52ab9b48f540daddadf288d3618f1ba4ba32506e 100644
--- a/chrome/browser/android/webapk/webapk_installer.h
+++ b/chrome/browser/android/webapk/webapk_installer.h
@@ -50,7 +50,6 @@ class WebApkInstaller : public net::URLFetcherDelegate {
const SkBitmap& badge_icon,
const FinishCallback& finish_callback);
- // TODO(zpeng): Add badge icon to WebAPK update route.
// Creates a self-owned WebApkInstaller instance and talks to the Chrome
// WebAPK server to update a WebAPK on the server and locally requests the
// APK to be installed. Calls |callback| once the install completed or failed.
@@ -58,6 +57,7 @@ class WebApkInstaller : public net::URLFetcherDelegate {
content::BrowserContext* context,
const ShortcutInfo& shortcut_info,
const SkBitmap& primary_icon,
+ const SkBitmap& badge_icon,
const std::string& webapk_package,
int webapk_version,
const std::map<std::string, std::string>& icon_url_to_murmur2_hash,
« no previous file with comments | « chrome/browser/android/webapk/webapk_install_service.cc ('k') | chrome/browser/android/webapk/webapk_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698