Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2636)

Unified Diff: chrome/browser/android/webapk/webapk_install_service.cc

Issue 2921623004: Support badge icon in WebAPK update components (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_install_service.cc
diff --git a/chrome/browser/android/webapk/webapk_install_service.cc b/chrome/browser/android/webapk/webapk_install_service.cc
index 49c7b5da035a056052066384128ca390f0adc022..2c027b24ccea58f90f64db7c9e505eefa163f5ae 100644
--- a/chrome/browser/android/webapk/webapk_install_service.cc
+++ b/chrome/browser/android/webapk/webapk_install_service.cc
@@ -43,7 +43,8 @@ void WebApkInstallService::InstallAsync(const ShortcutInfo& shortcut_info,
void WebApkInstallService::UpdateAsync(
const ShortcutInfo& shortcut_info,
- const SkBitmap& shortcut_icon,
+ const SkBitmap& primary_icon,
+ const SkBitmap& badge_icon,
const std::string& webapk_package,
int webapk_version,
const std::map<std::string, std::string>& icon_url_to_murmur2_hash,
@@ -54,7 +55,7 @@ void WebApkInstallService::UpdateAsync(
installs_.insert(shortcut_info.manifest_url);
WebApkInstaller::UpdateAsync(
- browser_context_, shortcut_info, shortcut_icon, webapk_package,
+ browser_context_, shortcut_info, primary_icon, badge_icon, webapk_package,
webapk_version, icon_url_to_murmur2_hash, is_manifest_stale,
base::Bind(&WebApkInstallService::OnFinishedInstall,
weak_ptr_factory_.GetWeakPtr(), shortcut_info.manifest_url,
« no previous file with comments | « chrome/browser/android/webapk/webapk_install_service.h ('k') | chrome/browser/android/webapk/webapk_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698