Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2921583003: VR: Content size incorrect when transitioning from webVR into VR Shell (Closed)

Created:
3 years, 6 months ago by billorr
Modified:
3 years, 6 months ago
Reviewers:
ymalik
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

VR: Content size incorrect when transitioning from webVR into VR Shell The issue here is we are setting the virtual display's size when we enter WebVR, but not when we exit it to VrShell. This means that content is incorrectly sized. The fix simply sets the virtual display's size when we exit WebVR to VrShell. BUG=718578 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2906173002 Cr-Original-Commit-Position: refs/heads/master@{#476074} Review-Url: https://codereview.chromium.org/2921583003 Cr-Commit-Position: refs/branch-heads/3112@{#108} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/079395cb4a1ae3e6267aada372111300602ceb2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 2 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921583003/1
3 years, 6 months ago (2017-06-02 00:48:44 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-02 00:48:46 UTC) #4
ymalik
lgtm
3 years, 6 months ago (2017-06-02 00:52:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921583003/1
3 years, 6 months ago (2017-06-02 00:53:52 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 6 months ago (2017-06-02 00:53:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921583003/1
3 years, 6 months ago (2017-06-02 00:55:28 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 00:56:03 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/079395cb4a1ae3e6267aada37211...

Powered by Google App Engine
This is Rietveld 408576698