Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2921573002: Milo UI tweaks (Closed)

Created:
3 years, 6 months ago by Ryan Tseng
Modified:
3 years, 6 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo UI tweaks * Changed "interesting" to "non-green only" * Added alternating colors for step links * Constrained properties value cell width to 250px * Reordered step title so right side would layout first * Moved some inline styles into default.css BUG=726449, 728207, 716692 Review-Url: https://codereview.chromium.org/2921573002 Committed: https://github.com/luci/luci-go/commit/1c9bfc6dd8d53a83332efae04b25611bb560660f

Patch Set 1 #

Patch Set 2 : Retrain #

Patch Set 3 : only -> Only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+580 lines, -666 lines) Patch
M milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html View 1 2 31 chunks +98 lines, -117 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot.build-Debug_page-_chromium_presubmit_426944.html View 1 2 27 chunks +80 lines, -90 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html View 1 2 43 chunks +149 lines, -178 lines 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-Basic_successful_build.html View 1 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-canceled.html View 1 2 6 chunks +17 lines, -20 lines 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-exception.html View 1 2 8 chunks +25 lines, -30 lines 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-expired.html View 1 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-finished-logdog-expired-stream.html View 1 2 5 chunks +6 lines, -7 lines 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-internal.html View 1 2 3 chunks +9 lines, -11 lines 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-link.html View 1 2 3 chunks +9 lines, -11 lines 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-nested.html View 1 2 13 chunks +35 lines, -43 lines 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-patch-failure.html View 1 2 10 chunks +36 lines, -41 lines 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-pending.html View 1 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-pending-logdog.html View 1 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-running.html View 1 2 6 chunks +19 lines, -23 lines 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-running-logdog.html View 1 2 6 chunks +20 lines, -24 lines 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-running-logdog-no-annotation-stream.html View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-timeout.html View 1 2 6 chunks +18 lines, -21 lines 0 comments Download
M milo/appengine/frontend/expectations/swarming.build-build-unicode.html View 1 2 6 chunks +19 lines, -23 lines 0 comments Download
M milo/appengine/frontend/static/buildbot/css/default.css View 3 chunks +16 lines, -0 lines 0 comments Download
M milo/appengine/frontend/templates/pages/build.html View 1 2 6 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
Ryan Tseng
ptal demo: https://1756-f5757f6-tainted-hinoka-dot-luci-milo-dev.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/470109
3 years, 6 months ago (2017-06-01 23:34:39 UTC) #16
nodir
lgtm lgtm
3 years, 6 months ago (2017-06-02 19:07:28 UTC) #17
nodir
lgtm
3 years, 6 months ago (2017-06-02 19:07:28 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921573002/40001
3 years, 6 months ago (2017-06-02 19:23:23 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 19:28:23 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/1c9bfc6dd8d53a83332efae04b25611bb560660f

Powered by Google App Engine
This is Rietveld 408576698