Track how often we successfully resolve non-'compliant' domain names.

Track how often we successfully resolve non-'compliant' domain names.

Add a counter to see how often we successfully resolve hostnames, tracking
whether or not |net::IsValidHostLabelCharacter| returns true for all characters
in all labels in the name.

BUG=695474
Review-Url: https://codereview.chromium.org/2921553002
Cr-Commit-Position: refs/heads/master@{#478761}
Committed: https://chromium.googlesource.com/chromium/src/+/6d7956de098e0a62f233ab334ac5271aba6864ef

[palmer, 2017-06-01 00:32:25]

palmer@chromium.org changed reviewers:
+ mpearson@chromium.org, rsleevi@chromium.org

[palmer, 2017-06-01 00:33:40]

The CQ bit was checked by palmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 00:34:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 01:35:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 01:35:43]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[palmer, 2017-06-02 01:56:38]

I'm going on vacation starting tomorrow. If this LGT both of Y, can you please
commit it? If not, I'll be back on the 12th. Thanks!

[Mark P, 2017-06-02 04:11:33]

histograms.xml lgtm

[Mark P, 2017-06-02 04:11:46]

histograms.xml lgtm

--mark

[Ryan Sleevi, 2017-06-02 13:39:55]

//net LGTM % nit

https://codereview.chromium.org/2921553002/diff/1/net/dns/host_resolver_proc.cc
File net/dns/host_resolver_proc.cc (right):

https://codereview.chromium.org/2921553002/diff/1/net/dns/host_resolver_proc....
net/dns/host_resolver_proc.cc:132: // no longer need the UMA metrics.
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/NH-S6KCkr2M

// Make sure |host| is properly formed. Record whether or not the name was valid
(see
// net::IsValidHostLabelCharacter), so that it's possible to measure how often
invalid
// names successfully resolve.
// TODO(https://crbug.com/695474): Remove this once invalid names are
consistently
// rejected.

[Mark P, 2017-06-02 17:47:46]

Submitting per palmer@'s request; the comment revision can clearly be done in a
follow-up changelist.

--mark

[Mark P, 2017-06-02 17:48:41]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:49:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 17:51:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:51:17]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mark P, 2017-06-02 18:16:37]

Needs rebasing.  Too much trouble for me to do on palmer@'s behalf; I imagine
this can wait until he returns.

--mark

[palmer, 2017-06-12 18:17:01]

The CQ bit was checked by palmer@chromium.org

[palmer, 2017-06-12 18:17:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org, rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/2921553002/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-06-12 18:17:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 19:22:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 19:22:37]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[palmer, 2017-06-12 19:30:36]

The CQ bit was checked by palmer@chromium.org

[palmer, 2017-06-12 19:30:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org, rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/2921553002/#ps40001
(title: "|valid_name| is now a pointer!")

[commit-bot: I haz the power, 2017-06-12 19:31:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 21:05:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497295836289980,
"parent_rev": "fcd03964f1bcd622d1efc230d6907adec9337759", "commit_rev":
"6d7956de098e0a62f233ab334ac5271aba6864ef"}

[commit-bot: I haz the power, 2017-06-12 21:05:42]

Description was changed from

==========
Track how often we successfully resolve non-'compliant' domain names.

Add a counter to see how often we successfully resolve hostnames, tracking
whether or not |net::IsValidHostLabelCharacter| returns true for all characters
in all labels in the name.

BUG=695474
==========

to

==========
Track how often we successfully resolve non-'compliant' domain names.

Add a counter to see how often we successfully resolve hostnames, tracking
whether or not |net::IsValidHostLabelCharacter| returns true for all characters
in all labels in the name.

BUG=695474

Review-Url: https://codereview.chromium.org/2921553002
Cr-Commit-Position: refs/heads/master@{#478761}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d7956de098e0a62f233ab334ac5...
==========

[commit-bot: I haz the power, 2017-06-12 21:05:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6d7956de098e0a62f233ab334ac5...