Fix a DCHECK ordering problem in ImageOperations.

Fix a DCHECK ordering problem in ImageOperations.

This moves a DCHECK below an ordered early out. The subset of an empty bitmap
with an empty rectangle is empty, and we should return an SkBitmap() before
performing a more general intersection check.

BUG=728736
Review-Url: https://codereview.chromium.org/2921533006
Cr-Commit-Position: refs/heads/master@{#477344}
Committed: https://chromium.googlesource.com/chromium/src/+/f5ed5f60a73da4d69a1c87dfe98523bba659a7f0

[Elliot Glaysher, 2017-06-02 22:19:42]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 22:20:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-06-02 22:22:46]

erg@chromium.org changed reviewers:
+ fmalita@chromium.org

[commit-bot: I haz the power, 2017-06-03 02:38:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-03 02:38:24]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[f(malita), 2017-06-03 22:48:07]

lgtm

[Elliot Glaysher, 2017-06-06 17:02:37]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2017-06-06 17:03:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 18:27:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496768557005160, "parent_rev":
"8acf7ed04acf24171f8928a26329a731955470e9", "commit_rev":
"f5ed5f60a73da4d69a1c87dfe98523bba659a7f0"}

[commit-bot: I haz the power, 2017-06-06 18:27:09]

Description was changed from

==========
Fix a DCHECK ordering problem in ImageOperations.

This moves a DCHECK below an ordered early out. The subset of an empty bitmap
with an empty rectangle is empty, and we should return an SkBitmap() before
performing a more general intersection check.

BUG=728736
==========

to

==========
Fix a DCHECK ordering problem in ImageOperations.

This moves a DCHECK below an ordered early out. The subset of an empty bitmap
with an empty rectangle is empty, and we should return an SkBitmap() before
performing a more general intersection check.

BUG=728736

Review-Url: https://codereview.chromium.org/2921533006
Cr-Commit-Position: refs/heads/master@{#477344}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5ed5f60a73da4d69a1c87dfe985...
==========

[commit-bot: I haz the power, 2017-06-06 18:27:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f5ed5f60a73da4d69a1c87dfe985...