Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2921533005: Settings: Network: Fix some spacing issues (Closed)

Created:
3 years, 6 months ago by stevenjb
Modified:
3 years, 6 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings: Network: Fix some spacing issues BUG=720024 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2921533005 Cr-Commit-Position: refs/heads/master@{#477024} Committed: https://chromium.googlesource.com/chromium/src/+/8b6dfd61bd8ad628f5606c96aec76c6e037dbddb

Patch Set 1 #

Total comments: 1

Patch Set 2 : Elim bogus intent class #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -38 lines) Patch
M chrome/browser/resources/settings/internet_page/internet_detail_page.html View 1 chunk +26 lines, -28 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_shared_css.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_property_list.html View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy.html View 1 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
stevenjb
Extracted from 2903233003 and simplified to take advantage of your latest layout fixes. https://codereview.chromium.org/2921533005/diff/1/chrome/browser/resources/settings/internet_page/internet_detail_page.html File ...
3 years, 6 months ago (2017-06-02 17:50:18 UTC) #3
stevenjb
PTAL
3 years, 6 months ago (2017-06-02 21:24:57 UTC) #4
dschuyler
lgtm
3 years, 6 months ago (2017-06-02 22:49:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921533005/40001
3 years, 6 months ago (2017-06-05 16:13:12 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 18:03:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8b6dfd61bd8ad628f5606c96aec7...

Powered by Google App Engine
This is Rietveld 408576698