Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

Issue 2921463004: [LayoutNG] PODify NGLayoutInputNode and sub-classes. (Closed)
Patch Set: new ng-bot expectations Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
index 6b465109af92381fd70ea9c020ecea348a25e807..d77086d1a6346fc5836b5a1c1c9b4fc40a16cb97 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
@@ -42,7 +42,7 @@ class CORE_EXPORT NGBlockLayoutAlgorithm
// @param space The constraint space which the algorithm should generate a
// fragment within.
// @param break_token The break token from which the layout should start.
- NGBlockLayoutAlgorithm(NGBlockNode* node,
+ NGBlockLayoutAlgorithm(NGBlockNode node,
NGConstraintSpace* space,
NGBlockBreakToken* break_token = nullptr);
@@ -50,22 +50,22 @@ class CORE_EXPORT NGBlockLayoutAlgorithm
virtual RefPtr<NGLayoutResult> Layout() override;
private:
- NGBoxStrut CalculateMargins(NGLayoutInputNode* child);
+ NGBoxStrut CalculateMargins(NGLayoutInputNode child);
// Creates a new constraint space for the current child.
RefPtr<NGConstraintSpace> CreateConstraintSpaceForChild(
- const NGLayoutInputNode& child,
+ const NGLayoutInputNode child,
const NGInflowChildData& child_data);
// @return Estimated BFC offset for the "to be layout" child.
NGInflowChildData PrepareChildLayout(const NGPreviousInflowPosition&,
- NGLayoutInputNode*);
+ NGLayoutInputNode);
NGPreviousInflowPosition FinishChildLayout(
const NGConstraintSpace&,
const NGPreviousInflowPosition& prev_data,
const NGInflowChildData& child_data,
- const NGLayoutInputNode* child,
+ const NGLayoutInputNode child,
NGLayoutResult*);
// Positions the fragment that establishes a new formatting context.
@@ -110,9 +110,9 @@ class CORE_EXPORT NGBlockLayoutAlgorithm
NGLogicalOffset PositionLegacy(const NGConstraintSpace& child_space,
const NGInflowChildData& child_data);
- void HandleOutOfFlowPositioned(const NGPreviousInflowPosition&, NGBlockNode*);
+ void HandleOutOfFlowPositioned(const NGPreviousInflowPosition&, NGBlockNode);
void HandleFloating(const NGPreviousInflowPosition&,
- NGBlockNode*,
+ NGBlockNode,
NGBlockBreakToken*);
// Final adjustments before fragment creation. We need to prevent the

Powered by Google App Engine
This is Rietveld 408576698