Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_child_iterator_test.cc

Issue 2921463004: [LayoutNG] PODify NGLayoutInputNode and sub-classes. (Closed)
Patch Set: new ng-bot expectations Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_block_child_iterator_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_child_iterator_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_child_iterator_test.cc
index e9203f9de6b913e3c8817709976c118cef825fff..799094364963304a44de3d29e5891791e48243ad 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_child_iterator_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_child_iterator_test.cc
@@ -26,10 +26,10 @@ TEST_F(NGBlockChildIteratorTest, NoBreakToken) {
<div id='child2'></div>
<div id='child3'></div>
)HTML");
- NGLayoutInputNode* node1 =
- new NGBlockNode(ToLayoutBlockFlow(GetLayoutObjectByElementId("child1")));
- NGLayoutInputNode* node2 = node1->NextSibling();
- NGLayoutInputNode* node3 = node2->NextSibling();
+ NGLayoutInputNode node1 =
+ NGBlockNode(ToLayoutBox(GetLayoutObjectByElementId("child1")));
+ NGLayoutInputNode node2 = node1.NextSibling();
+ NGLayoutInputNode node3 = node2.NextSibling();
// The iterator should loop through three children.
NGBlockChildIterator iterator(node1, nullptr);
@@ -48,11 +48,11 @@ TEST_F(NGBlockChildIteratorTest, BreakTokenWithFinishedChild) {
<div id='child3'></div>
</div>
)HTML");
- NGBlockNode* container = new NGBlockNode(
- ToLayoutBlockFlow(GetLayoutObjectByElementId("container")));
- NGLayoutInputNode* node1 = container->FirstChild();
- NGLayoutInputNode* node2 = node1->NextSibling();
- NGLayoutInputNode* node3 = node2->NextSibling();
+ NGBlockNode container =
+ NGBlockNode(ToLayoutBox(GetLayoutObjectByElementId("container")));
+ NGLayoutInputNode node1 = container.FirstChild();
+ NGLayoutInputNode node2 = node1.NextSibling();
+ NGLayoutInputNode node3 = node2.NextSibling();
Vector<RefPtr<NGBreakToken>> child_break_tokens;
child_break_tokens.push_back(NGBlockBreakToken::Create(node1));
@@ -86,11 +86,11 @@ TEST_F(NGBlockChildIteratorTest, BreakTokenWithUnFinishedChild) {
<div id='child3'></div>
</div>
)HTML");
- NGBlockNode* container = new NGBlockNode(
- ToLayoutBlockFlow(GetLayoutObjectByElementId("container")));
- NGLayoutInputNode* node1 = container->FirstChild();
- NGLayoutInputNode* node2 = node1->NextSibling();
- NGLayoutInputNode* node3 = node2->NextSibling();
+ NGBlockNode container =
+ NGBlockNode(ToLayoutBox(GetLayoutObjectByElementId("container")));
+ NGLayoutInputNode node1 = container.FirstChild();
+ NGLayoutInputNode node2 = node1.NextSibling();
+ NGLayoutInputNode node3 = node2.NextSibling();
Vector<RefPtr<NGBreakToken>> child_break_tokens;
RefPtr<NGBreakToken> child_token =

Powered by Google App Engine
This is Rietveld 408576698