third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h - Issue 2921463004: [LayoutNG] PODify NGLayoutInputNode and sub-classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h

Issue 2921463004: [LayoutNG] PODify NGLayoutInputNode and sub-classes. (Closed)

Patch Set: new ng-bot expectations Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node_test.cc ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h

index cc9ae0cae9d1e8ba03af5c906bdd4eecd8e432e7..a5e4ad8ae2cac8721dd179b5a33675ede6d9de58 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h

@@ -20,7 +20,7 @@ class CORE_EXPORT NGLineBoxFragmentBuilder final {

STACK_ALLOCATED();

public:

- explicit NGLineBoxFragmentBuilder(NGInlineNode*);

+ explicit NGLineBoxFragmentBuilder(NGInlineNode);

NGLineBoxFragmentBuilder& SetWritingMode(NGWritingMode);

NGWritingMode WritingMode() const { return writing_mode_; }

@@ -55,7 +55,7 @@ class CORE_EXPORT NGLineBoxFragmentBuilder final {

NGWritingMode writing_mode_;

TextDirection direction_;

- Persistent<NGInlineNode> node_;

+ NGInlineNode node_;

LayoutUnit inline_size_;