third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc - Issue 2921463004: [LayoutNG] PODify NGLayoutInputNode and sub-classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc

Issue 2921463004: [LayoutNG] PODify NGLayoutInputNode and sub-classes. (Closed)

Patch Set: new ng-bot expectations Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc

index 6def2c780dbf15197e63641592db7c7c7844393e..1d66644c4806fd590b46146c42b9546e71f27c08 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc

@@ -13,7 +13,7 @@

namespace blink {

-NGLineBoxFragmentBuilder::NGLineBoxFragmentBuilder(NGInlineNode* node)

+NGLineBoxFragmentBuilder::NGLineBoxFragmentBuilder(NGInlineNode node)

: writing_mode_(kHorizontalTopBottom),

direction_(TextDirection::kLtr),

node_(node) {}

@@ -71,7 +71,7 @@ NGLineBoxFragmentBuilder::ToLineBoxFragment() {

DCHECK_EQ(offsets_.size(), children_.size());

NGWritingMode writing_mode(

- FromPlatformWritingMode(node_->Style().GetWritingMode()));

+ FromPlatformWritingMode(node_.Style().GetWritingMode()));

NGPhysicalSize physical_size =

NGLogicalSize(inline_size_, Metrics().LineHeight())

.ConvertToPhysical(writing_mode);