Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2921413002: [CRD iOS] Finish up the host list UI (Closed)

Created:
3 years, 6 months ago by Yuwei
Modified:
3 years, 6 months ago
Reviewers:
nicholss
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CRD iOS] Finish up the host list UI This CL finishes up matching the host list UX mocks. It: * Changes the menu and refresh icon * Adds title for the app bar * Adds the "Remote devices" section header Screenshots: https://drive.google.com/file/d/0BytzIZKeM8nBZ255YmxxeTBPajQ/view?usp=sharing https://drive.google.com/file/d/0BytzIZKeM8nBd0g0cjRWSWlJSlE/view?usp=sharing BUG=728280 Review-Url: https://codereview.chromium.org/2921413002 Cr-Commit-Position: refs/heads/master@{#477462} Committed: https://chromium.googlesource.com/chromium/src/+/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : Added sources to the target. Hopefully it will fix the issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -18 lines) Patch
M remoting/ios/app/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A remoting/ios/app/host_collection_header_view.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
A remoting/ios/app/host_collection_header_view.mm View 1 1 chunk +57 lines, -0 lines 0 comments Download
M remoting/ios/app/host_collection_view_controller.mm View 5 chunks +30 lines, -1 line 0 comments Download
M remoting/ios/app/remoting_view_controller.mm View 1 chunk +14 lines, -9 lines 0 comments Download
M remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_menu.imageset/Contents.json View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
A remoting/ios/app/resources/Assets.xcassets/ic_menu.imageset/ic_menu_white.png View Binary file 0 comments Download
A remoting/ios/app/resources/Assets.xcassets/ic_menu.imageset/ic_menu_white_2x.png View Binary file 0 comments Download
A remoting/ios/app/resources/Assets.xcassets/ic_menu.imageset/ic_menu_white_3x.png View Binary file 0 comments Download
A + remoting/ios/app/resources/Assets.xcassets/ic_refresh.imageset/Contents.json View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
A remoting/ios/app/resources/Assets.xcassets/ic_refresh.imageset/ic_refresh_white.png View Binary file 0 comments Download
A remoting/ios/app/resources/Assets.xcassets/ic_refresh.imageset/ic_refresh_white_2x.png View Binary file 0 comments Download
A remoting/ios/app/resources/Assets.xcassets/ic_refresh.imageset/ic_refresh_white_3x.png View Binary file 0 comments Download
M remoting/ios/app/resources/BUILD.gn View 1 2 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Yuwei
PTAL thanks! The icon colors may still need some final tweaks but it's pretty close ...
3 years, 6 months ago (2017-06-06 18:43:04 UTC) #3
nicholss
lgtm
3 years, 6 months ago (2017-06-06 20:19:01 UTC) #4
Yuwei
Thanks!
3 years, 6 months ago (2017-06-06 20:48:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921413002/20001
3 years, 6 months ago (2017-06-06 20:48:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921413002/40001
3 years, 6 months ago (2017-06-06 21:58:15 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 23:36:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3c9d15f88ffe157a9f4a3b74e33a...

Powered by Google App Engine
This is Rietveld 408576698