Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2921363002: DevTools: Add keyboard focus highlight when focusing window (Closed)

Created:
3 years, 6 months ago by einbinder
Modified:
3 years, 6 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Add keyboard focus highlight when focusing window This adds data-keyboard-focus when the user focuses devtools by keyboard or focus wraps around the devtools page. BUG=706699 Review-Url: https://codereview.chromium.org/2921363002 Cr-Commit-Position: refs/heads/master@{#477544} Committed: https://chromium.googlesource.com/chromium/src/+/8460a371d21057323a77b7acedc5bf1f73674020

Patch Set 1 #

Total comments: 2

Patch Set 2 : move listener to windowFocused #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
einbinder
ptal
3 years, 6 months ago (2017-06-05 22:28:50 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2921363002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js File third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js (right): https://codereview.chromium.org/2921363002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js#newcode1141 third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js:1141: document.addEventListener('mousedown', () => { Let's move this listener ...
3 years, 6 months ago (2017-06-06 22:10:30 UTC) #3
einbinder
https://codereview.chromium.org/2921363002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js File third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js (right): https://codereview.chromium.org/2921363002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js#newcode1141 third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js:1141: document.addEventListener('mousedown', () => { On 2017/06/06 at 22:10:30, dgozman ...
3 years, 6 months ago (2017-06-07 02:01:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921363002/20001
3 years, 6 months ago (2017-06-07 02:02:39 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 04:16:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8460a371d21057323a77b7acedc5...

Powered by Google App Engine
This is Rietveld 408576698