DevTools: Add keyboard focus highlight when focusing window

DevTools: Add keyboard focus highlight when focusing window

This adds data-keyboard-focus when the user focuses devtools by keyboard
or focus wraps around the devtools page.

BUG=706699
Review-Url: https://codereview.chromium.org/2921363002
Cr-Commit-Position: refs/heads/master@{#477544}
Committed: https://chromium.googlesource.com/chromium/src/+/8460a371d21057323a77b7acedc5bf1f73674020

[einbinder, 2017-06-05 22:28:50]

einbinder@chromium.org changed reviewers:
+ dgozman@chromium.org

[einbinder, 2017-06-05 22:28:50]

ptal

[dgozman, 2017-06-06 22:10:30]

lgtm

https://codereview.chromium.org/2921363002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js (right):

https://codereview.chromium.org/2921363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js:1141:
document.addEventListener('mousedown', () => {
Let's move this listener to _windowFocused.

[einbinder, 2017-06-07 02:01:44]

https://codereview.chromium.org/2921363002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js (right):

https://codereview.chromium.org/2921363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js:1141:
document.addEventListener('mousedown', () => {
On 2017/06/06 at 22:10:30, dgozman wrote:
> Let's move this listener to _windowFocused.

Done.

[einbinder, 2017-06-07 02:02:18]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2017-06-07 02:02:19]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2921363002/#ps20001
(title: "move listener to windowFocused")

[commit-bot: I haz the power, 2017-06-07 02:02:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 04:16:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496800938769570,
"parent_rev": "ad1fa53a1d42f9726a296a9fce1be2f89b714d7e", "commit_rev":
"8460a371d21057323a77b7acedc5bf1f73674020"}

[commit-bot: I haz the power, 2017-06-07 04:16:45]

Description was changed from

==========
DevTools: Add keyboard focus highlight when focusing window

This adds data-keyboard-focus when the user focuses devtools by keyboard
or focus wraps around the devtools page.

BUG=706699
==========

to

==========
DevTools: Add keyboard focus highlight when focusing window

This adds data-keyboard-focus when the user focuses devtools by keyboard
or focus wraps around the devtools page.

BUG=706699

Review-Url: https://codereview.chromium.org/2921363002
Cr-Commit-Position: refs/heads/master@{#477544}
Committed:
https://chromium.googlesource.com/chromium/src/+/8460a371d21057323a77b7acedc5...
==========

[commit-bot: I haz the power, 2017-06-07 04:16:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8460a371d21057323a77b7acedc5...