Improve documentation and tests for base::OnTaskRunnerDeleter.

Improve documentation and tests for base::OnTaskRunnerDeleter.

And cross-documentation from BrowserThread::DeleteOnThread (ref. crbug.com/729210).

Modernized the tests while trying to make OnTaskRunnerDeleter work for
RefCounted until I realized it wouldn't work as-is, still better than
nothing for now and will help cleaner follow-up.

BUG=729210
Review-Url: https://codereview.chromium.org/2921343002
Cr-Commit-Position: refs/heads/master@{#477661}
Committed: https://chromium.googlesource.com/chromium/src/+/98dee7702162992e0f0a605c09879f0bde1ce987

[gab, 2017-06-05 21:26:05]

gab@chromium.org changed reviewers:
+ jam@chromium.org, thestig@chromium.org

[gab, 2017-06-05 21:26:06]

Lei/John PTaL, thanks!

[gab, 2017-06-05 21:26:09]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 21:27:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-06-05 21:27:16]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 21:27:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 23:47:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 23:47:47]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gab, 2017-06-06 03:43:26]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 03:43:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 04:53:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 04:53:33]

Dry run: This issue passed the CQ dry run.

[gab, 2017-06-06 17:54:31]

gab@chromium.org changed reviewers:
+ danakj@chromium.org

[gab, 2017-06-06 17:54:32]

+Dana looks like Lei is away and you're back.. :)

[Lei Zhang, 2017-06-07 00:58:03]

thestig@chromium.org changed reviewers:
+ tzik@chromium.org

[Lei Zhang, 2017-06-07 00:58:03]

Adding tzik who actually wrote base/sequenced_task_runner_unittest.cc.

[jam, 2017-06-07 01:20:12]

content lgtm

[tzik, 2017-06-07 09:41:05]

lgtm

[gab, 2017-06-07 13:26:14]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-06-07 13:26:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 15:49:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496841974127590,
"parent_rev": "22af497bd72d37d4da5c7e3398af8a8bf0211cc9", "commit_rev":
"98dee7702162992e0f0a605c09879f0bde1ce987"}

[commit-bot: I haz the power, 2017-06-07 15:49:16]

Description was changed from

==========
Improve documentation and tests for base::OnTaskRunnerDeleter.

And cross-documentation from BrowserThread::DeleteOnThread (ref.
crbug.com/729210).

Modernized the tests while trying to make OnTaskRunnerDeleter work for
RefCounted until I realized it wouldn't work as-is, still better than
nothing for now and will help cleaner follow-up.

BUG=729210
==========

to

==========
Improve documentation and tests for base::OnTaskRunnerDeleter.

And cross-documentation from BrowserThread::DeleteOnThread (ref.
crbug.com/729210).

Modernized the tests while trying to make OnTaskRunnerDeleter work for
RefCounted until I realized it wouldn't work as-is, still better than
nothing for now and will help cleaner follow-up.

BUG=729210

Review-Url: https://codereview.chromium.org/2921343002
Cr-Commit-Position: refs/heads/master@{#477661}
Committed:
https://chromium.googlesource.com/chromium/src/+/98dee7702162992e0f0a605c0987...
==========

[commit-bot: I haz the power, 2017-06-07 15:49:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/98dee7702162992e0f0a605c0987...