Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2921283002: Need to update last_slot when unprovisioned_bytes && discard. (Closed)

Created:
3 years, 6 months ago by tasak
Modified:
3 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME), Mads Ager (chromium), vmpstr+watch_chromium.org, wfh+watch_chromium.org, oilpan-reviews, danakj+watch_chromium.org, kouhei+heap_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Need to update last_slot when unprovisioned_bytes && discard. last_slot points the last node of PartitionFreelistEntry freelist. However, when truncating slots, the freelist is reordered. So last_slot calculated previously is not valid. BUG= Review-Url: https://codereview.chromium.org/2921283002 Cr-Commit-Position: refs/heads/master@{#478222} Committed: https://chromium.googlesource.com/chromium/src/+/9de3fa20ec0b7a98321b1cb045d7ba5414e8e0e9

Patch Set 1 #

Patch Set 2 : Fixed PartitionAllocTest.PurgeDiscardable failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/allocator/partition_allocator/partition_alloc.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
tasak
Would you review this CL? I need this CL to test the flag: base::PartitionPurgeDiscardUnusedSystemPages.
3 years, 6 months ago (2017-06-05 11:47:47 UTC) #4
haraken
LGTM
3 years, 6 months ago (2017-06-05 12:23:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921283002/20001
3 years, 6 months ago (2017-06-09 05:54:57 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 07:20:58 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9de3fa20ec0b7a98321b1cb045d7...

Powered by Google App Engine
This is Rietveld 408576698