Autoplay: add document user activation flag in chrome://flags

Autoplay: add document user activation flag in chrome://flags

This is plumbing the flag to Blink. The feature is not fully implemented
but can be tested. The missing parts are:
- Media Engagement Index;
- Iframe delecation;
- Sticky bit across navigations.

BUG=715049
Review-Url: https://codereview.chromium.org/2921273002
Cr-Commit-Position: refs/heads/master@{#477238}
Committed: https://chromium.googlesource.com/chromium/src/+/431bb4ec952257a3a60c3554fdf039d0692a0b64

[mlamouri (slow - plz ping), 2017-06-05 10:32:33]

mlamouri@chromium.org changed reviewers:
+ chcunningham@chromium.org, nasko@chromium.org

[mlamouri (slow - plz ping), 2017-06-05 10:32:34]

Can you all PTAL at:

chcunningham@:
  media/base/media_switches.cc
  media/base/media_switches.h

nasko@
  content/browser/renderer_host/render_view_host_impl.cc
  content/public/common/common_param_traits_macros.h
  content/public/common/web_preferences.h
  content/renderer/render_view_impl.cc

Thanks :)

The feature is test in Blink with LayoutTests.

[mlamouri (slow - plz ping), 2017-06-05 16:44:44]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 16:44:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chcunningham, 2017-06-05 17:08:31]

media LGTM

[commit-bot: I haz the power, 2017-06-05 18:48:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 18:48:06]

Dry run: This issue passed the CQ dry run.

[nasko, 2017-06-05 23:48:11]

content/ LGTM

https://codereview.chromium.org/2921273002/diff/1/content/public/common/web_p...
File content/public/common/web_preferences.h (right):

https://codereview.chromium.org/2921273002/diff/1/content/public/common/web_p...
content/public/common/web_preferences.h:70: // WebSettings.h.
note: It would've been best if WebSettings.h change ensured that this file was
also changed.

[mlamouri (slow - plz ping), 2017-06-06 08:49:31]

https://codereview.chromium.org/2921273002/diff/1/content/public/common/web_p...
File content/public/common/web_preferences.h (right):

https://codereview.chromium.org/2921273002/diff/1/content/public/common/web_p...
content/public/common/web_preferences.h:70: // WebSettings.h.
On 2017/06/05 at 23:48:11, nasko (slow) wrote:
> note: It would've been best if WebSettings.h change ensured that this file was
also changed.

FWIW, the changes were split on purpose so I could implement the feature in
Blink and write tests without having the feature exposed to our users. This
said, I don't know how we could have had an automatic way to make this check.
Any pointer?

[mlamouri (slow - plz ping), 2017-06-06 08:49:37]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2017-06-06 08:49:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 08:54:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496738977513110, "parent_rev":
"472a29c7b827847a9967d16f324d058a8d3fd270", "commit_rev":
"431bb4ec952257a3a60c3554fdf039d0692a0b64"}

[commit-bot: I haz the power, 2017-06-06 08:54:38]

Description was changed from

==========
Autoplay: add document user activation flag in chrome://flags

This is plumbing the flag to Blink. The feature is not fully implemented
but can be tested. The missing parts are:
- Media Engagement Index;
- Iframe delecation;
- Sticky bit across navigations.

BUG=715049
==========

to

==========
Autoplay: add document user activation flag in chrome://flags

This is plumbing the flag to Blink. The feature is not fully implemented
but can be tested. The missing parts are:
- Media Engagement Index;
- Iframe delecation;
- Sticky bit across navigations.

BUG=715049

Review-Url: https://codereview.chromium.org/2921273002
Cr-Commit-Position: refs/heads/master@{#477238}
Committed:
https://chromium.googlesource.com/chromium/src/+/431bb4ec952257a3a60c3554fdf0...
==========

[commit-bot: I haz the power, 2017-06-06 08:54:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/431bb4ec952257a3a60c3554fdf0...