Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2921253002: Revert of desktop_aura: do not restore focused view if it has modal transient child (Closed)

Created:
3 years, 6 months ago by blundell
Modified:
3 years, 6 months ago
Reviewers:
sky, Qiang(Joe) Xu
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of desktop_aura: do not restore focused view if it has modal transient child (patchset #3 id:40001 of https://codereview.chromium.org/2919973002/ ) Reason for revert: The newly-added test is flaky: https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySwsSBUZsYWtlIkBXaWRnZXRUZXN0SW50ZXJhY3RpdmUuRGVza3RvcE5hdGl2ZVdpZGdldFdpdGhNb2RhbFRyYW5zaWVudENoaWxkDA Reverting the CL rather than disabling the test as it's not clear where the flake is coming from: is it a problem in the test or in the production code added in this CL? Original issue's description: > desktop_aura: do not restore focused view if it has modal transient child > > Changes: > RestoreFocusedView on DesktopNativeWidgetAura::HandleActivationChanged is added to process Linux desktop native widget asynchronous activation. This works when all the child widgets are managed by top level's FocusManager. However, this is not true for modal transient child, whose FocusManager is not the same as top level's FocusManager. In this case on activation, we shall not restore focused view on top level's FocusManager. Instead, the modal transient child window will get activated and restore focused view through its own NativeWidgetAura::OnWindowActivated. > > BUG=727641 > TEST=emulator test saw bug fixed and added test coverage > > Review-Url: https://codereview.chromium.org/2919973002 > Cr-Commit-Position: refs/heads/master@{#476835} > Committed: https://chromium.googlesource.com/chromium/src/+/81ead2ab2380d5f624b9ce63df050a76de134f06 TBR=sky@chromium.org,warx@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=727641 Review-Url: https://codereview.chromium.org/2921253002 Cr-Commit-Position: refs/heads/master@{#476970} Committed: https://chromium.googlesource.com/chromium/src/+/a796415316eb8e7c8a6f1e746b837f8f24a60382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -58 lines) Patch
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +5 lines, -12 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
blundell
Created Revert of desktop_aura: do not restore focused view if it has modal transient child
3 years, 6 months ago (2017-06-05 09:57:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921253002/1
3 years, 6 months ago (2017-06-05 09:58:06 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 10:56:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a796415316eb8e7c8a6f1e746b83...

Powered by Google App Engine
This is Rietveld 408576698