Chromium Code Reviews
DescriptionRevert of desktop_aura: do not restore focused view if it has modal transient child (patchset #3 id:40001 of https://codereview.chromium.org/2919973002/ )
Reason for revert:
The newly-added test is flaky:
https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySwsSBUZsYWtlIkBXaWRnZXRUZXN0SW50ZXJhY3RpdmUuRGVza3RvcE5hdGl2ZVdpZGdldFdpdGhNb2RhbFRyYW5zaWVudENoaWxkDA
Reverting the CL rather than disabling the test as it's not clear where the flake is coming from: is it a problem in the test or in the production code added in this CL?
Original issue's description:
> desktop_aura: do not restore focused view if it has modal transient child
>
> Changes:
> RestoreFocusedView on DesktopNativeWidgetAura::HandleActivationChanged is added to process Linux desktop native widget asynchronous activation. This works when all the child widgets are managed by top level's FocusManager. However, this is not true for modal transient child, whose FocusManager is not the same as top level's FocusManager. In this case on activation, we shall not restore focused view on top level's FocusManager. Instead, the modal transient child window will get activated and restore focused view through its own NativeWidgetAura::OnWindowActivated.
>
> BUG=727641
> TEST=emulator test saw bug fixed and added test coverage
>
> Review-Url: https://codereview.chromium.org/2919973002
> Cr-Commit-Position: refs/heads/master@{#476835}
> Committed: https://chromium.googlesource.com/chromium/src/+/81ead2ab2380d5f624b9ce63df050a76de134f06
TBR=sky@chromium.org,warx@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=727641
Review-Url: https://codereview.chromium.org/2921253002
Cr-Commit-Position: refs/heads/master@{#476970}
Committed: https://chromium.googlesource.com/chromium/src/+/a796415316eb8e7c8a6f1e746b837f8f24a60382
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
||||||||||||||||||||||||||||