Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 2921243002: [CSS Typed OM] Add setters for the CSSNumericValues contained in CSSSkew (Closed)

Created:
3 years, 6 months ago by meade_UTC10
Modified:
3 years, 6 months ago
Reviewers:
rjwright
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CSS Typed OM] Add setters for the CSSNumericValues contained in CSSSkew Spec: https://drafts.css-houdini.org/css-typed-om/#cssskew BUG=545318 Review-Url: https://codereview.chromium.org/2921243002 Cr-Commit-Position: refs/heads/master@{#479296} Committed: https://chromium.googlesource.com/chromium/src/+/8f465a766c70edbe623a1c005357aa7e1f78773c

Patch Set 1 #

Patch Set 2 : Update test #

Patch Set 3 : fix missing idl change #

Patch Set 4 : Update global interface expectation #

Patch Set 5 : rebase #

Patch Set 6 : Fix missed global interface listing expectations #

Patch Set 7 : Rebase #

Messages

Total messages: 18 (13 generated)
meade_UTC10
3 years, 6 months ago (2017-06-05 10:01:59 UTC) #2
meade_UTC10
Hi Renee, PTAL
3 years, 6 months ago (2017-06-05 10:02:10 UTC) #3
rjwright
On 2017/06/05 10:02:10, meade_UTC10 wrote: > Hi Renee, PTAL LGTM
3 years, 6 months ago (2017-06-07 07:05:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921243002/120001
3 years, 6 months ago (2017-06-14 03:34:19 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 05:36:09 UTC) #18
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/8f465a766c70edbe623a1c005357...

Powered by Google App Engine
This is Rietveld 408576698