Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2921113002: Adds missing include. (Closed)

Created:
3 years, 6 months ago by Jana
Modified:
3 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds missing include. R=rch@chromium.org BUG= Review-Url: https://codereview.chromium.org/2921113002 Cr-Commit-Position: refs/heads/master@{#476866} Committed: https://chromium.googlesource.com/chromium/src/+/3ad08a4885eb537aa4c071fa356f6636ae71d9f8

Patch Set 1 #

Patch Set 2 : Adds header where used. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M net/quic/quartc/quartc_factory.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quartc/quartc_factory_interface.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quartc/quartc_packet_writer.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quartc/quartc_session.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quartc/quartc_session_interface.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quartc/quartc_stream.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quartc/quartc_stream_interface.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jana
3 years, 6 months ago (2017-06-02 23:24:32 UTC) #1
Ryan Hamilton
I think you need to add this to all the quartc files which have QUIC_EXPORT_PRIVATE ...
3 years, 6 months ago (2017-06-02 23:26:12 UTC) #2
Jana
On 2017/06/02 23:26:12, Ryan Hamilton wrote: > I think you need to add this to ...
3 years, 6 months ago (2017-06-02 23:32:56 UTC) #3
Ryan Hamilton
lgtm
3 years, 6 months ago (2017-06-02 23:33:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921113002/20001
3 years, 6 months ago (2017-06-02 23:34:05 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-03 02:25:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3ad08a4885eb537aa4c071fa356f...

Powered by Google App Engine
This is Rietveld 408576698