Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2921103002: Settings: Cookies: Avoid duplicate 'incognito' exceptions in CrOS Guest mode (Closed)

Created:
3 years, 6 months ago by stevenjb
Modified:
3 years, 6 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings: Cookies: Avoid duplicate 'incognito' exceptions in CrOS Guest mode BUG=725425 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2921103002 Cr-Commit-Position: refs/heads/master@{#477531} Committed: https://chromium.googlesource.com/chromium/src/+/711fb3b4e484eb70f5a89bbbbbc9a741d23cb427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/resources/settings/site_settings/add_site_dialog.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/site_settings_handler.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
stevenjb
3 years, 6 months ago (2017-06-02 23:19:18 UTC) #3
michaelpg
lgtm
3 years, 6 months ago (2017-06-07 00:49:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921103002/1
3 years, 6 months ago (2017-06-07 01:38:25 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 02:56:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/711fb3b4e484eb70f5a89bbbbbc9...

Powered by Google App Engine
This is Rietveld 408576698