Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Issue 2921093002: Disable flaky test testImportantSitesDialogNoopOnCancel (Closed)

Created:
3 years, 6 months ago by michaelbai
Modified:
3 years, 6 months ago
Reviewers:
Ted C, Theresa
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky test testImportantSitesDialogNoopOnCancel BUG=727310 Review-Url: https://codereview.chromium.org/2921093002 Cr-Commit-Position: refs/heads/master@{#476847} Committed: https://chromium.googlesource.com/chromium/src/+/3d5468a17e28d917b1ec26196e2241a121145f8d

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
michaelbai
3 years, 6 months ago (2017-06-02 21:49:58 UTC) #2
michaelbai
PTAL
3 years, 6 months ago (2017-06-02 21:51:09 UTC) #7
Theresa
lgtm % comment In general, as a sheriff it is appropriate to TBR test owners ...
3 years, 6 months ago (2017-06-02 21:52:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921093002/20001
3 years, 6 months ago (2017-06-02 22:03:38 UTC) #11
michaelbai
thanks https://codereview.chromium.org/2921093002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java (right): https://codereview.chromium.org/2921093002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java#newcode513 chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java:513: @DisabledTest On 2017/06/02 21:52:43, Theresa wrote: > @DisabledTest(message ...
3 years, 6 months ago (2017-06-02 22:03:52 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-03 01:21:37 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3d5468a17e28d917b1ec26196e22...

Powered by Google App Engine
This is Rietveld 408576698