Fix process reuse for dedicated processes when over process limit.

content/public/test/mock_render_process_host.cc

Index: content/public/test/mock_render_process_host.cc
diff --git a/content/public/test/mock_render_process_host.cc b/content/public/test/mock_render_process_host.cc
index 878462df64540bcff20222e5beb4ae36ae766cdc..78952eea266f936db605d1109e761b1692d3251c 100644
--- a/content/public/test/mock_render_process_host.cc
+++ b/content/public/test/mock_render_process_host.cc
@@ -46,6 +46,7 @@ MockRenderProcessHost::MockRenderProcessHost(BrowserContext* browser_context)
       deletion_callback_called_(false),
       is_for_guests_only_(false),
       is_process_backgrounded_(false),
+      can_become_dedicated_process_(true),
       worker_ref_count_(0) {
   // Child process security operations can't be unit tested unless we add
   // ourselves as an existing child process.
@@ -296,6 +297,7 @@ size_t MockRenderProcessHost::GetWorkerRefCount() const {
 
 void MockRenderProcessHost::IncrementServiceWorkerRefCount() {
   ++worker_ref_count_;
+  UnsetCanBecomeDedicatedProcess();

[Charlie Reis, 2017/06/12 23:08:17]

It's not obvious why these need to be here in MockRenderProcessHost but not
RenderProcessHostImpl.  If it's because the mock case won't have the same
context as the real case, it might be worth a comment to that effect.

[alexmos, 2017/06/14 22:39:05]

Ah, good catch.  These shouldn't be here, I just forgot to clean them up.  I
started out by doing this in both RenderProcessHostImpl and
MockRenderProcessHost but then persuaded myself that it isn't needed (see
https://codereview.chromium.org/2921063003/diff/80001/content/browser/rendere...)

 }
 
 void MockRenderProcessHost::DecrementServiceWorkerRefCount() {
@@ -304,6 +306,7 @@ void MockRenderProcessHost::DecrementServiceWorkerRefCount() {
 
 void MockRenderProcessHost::IncrementSharedWorkerRefCount() {
   ++worker_ref_count_;
+  UnsetCanBecomeDedicatedProcess();
 }
 
 void MockRenderProcessHost::DecrementSharedWorkerRefCount() {
@@ -338,6 +341,14 @@ bool MockRenderProcessHost::MayReuseHost() {
   return true;
 }
 
+bool MockRenderProcessHost::CanBecomeDedicatedProcess() {
+  return can_become_dedicated_process_;
+}
+
+void MockRenderProcessHost::UnsetCanBecomeDedicatedProcess() {
+  can_become_dedicated_process_ = false;
+}
+
 void MockRenderProcessHost::FilterURL(bool empty_allowed, GURL* url) {
   RenderProcessHostImpl::FilterURL(this, empty_allowed, url);
 }