Fix process reuse for dedicated processes when over process limit.

content/public/test/mock_render_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/test/mock_render_process_host.h"
 
 #include <algorithm>
 #include <utility>
 #include <vector>
 
@@ skipping 28 matching lines @@
     : bad_msg_count_(0),
       factory_(NULL),
       id_(ChildProcessHostImpl::GenerateChildProcessUniqueId()),
       has_connection_(false),
       browser_context_(browser_context),
       prev_routing_id_(0),
       fast_shutdown_started_(false),
       deletion_callback_called_(false),
       is_for_guests_only_(false),
       is_process_backgrounded_(false),
+      can_become_dedicated_process_(true),
       worker_ref_count_(0) {
   // Child process security operations can't be unit tested unless we add
   // ourselves as an existing child process.
   ChildProcessSecurityPolicyImpl::GetInstance()->Add(GetID());
 
   RenderProcessHostImpl::RegisterHost(GetID(), this);
 }
 
 MockRenderProcessHost::~MockRenderProcessHost() {
   ChildProcessSecurityPolicyImpl::GetInstance()->Remove(GetID());
@@ skipping 230 matching lines @@
 bool MockRenderProcessHost::IsProcessBackgrounded() const {
   return is_process_backgrounded_;
 }
 
 size_t MockRenderProcessHost::GetWorkerRefCount() const {
   return worker_ref_count_;
 }
 
 void MockRenderProcessHost::IncrementServiceWorkerRefCount() {
   ++worker_ref_count_;
+  UnsetCanBecomeDedicatedProcess();

[Charlie Reis, 2017/06/12 23:08:17]

It's not obvious why these need to be here in MockRenderProcessHost but not
RenderProcessHostImpl.  If it's because the mock case won't have the same
context as the real case, it might be worth a comment to that effect.

[alexmos, 2017/06/14 22:39:05]

Ah, good catch.  These shouldn't be here, I just forgot to clean them up.  I
started out by doing this in both RenderProcessHostImpl and
MockRenderProcessHost but then persuaded myself that it isn't needed (see
https://codereview.chromium.org/2921063003/diff/80001/content/browser/rendere...)

 }
 
 void MockRenderProcessHost::DecrementServiceWorkerRefCount() {
   --worker_ref_count_;
 }
 
 void MockRenderProcessHost::IncrementSharedWorkerRefCount() {
   ++worker_ref_count_;
+  UnsetCanBecomeDedicatedProcess();
 }
 
 void MockRenderProcessHost::DecrementSharedWorkerRefCount() {
   --worker_ref_count_;
 }
 
 void MockRenderProcessHost::ForceReleaseWorkerRefCounts() {
   worker_ref_count_ = 0;
 }
 
@@ skipping 14 matching lines @@
 }
 
 void MockRenderProcessHost::SetIsNeverSuitableForReuse() {
   NOTREACHED();
 }
 
 bool MockRenderProcessHost::MayReuseHost() {
   return true;
 }
 
+bool MockRenderProcessHost::CanBecomeDedicatedProcess() {
+  return can_become_dedicated_process_;
+}
+
+void MockRenderProcessHost::UnsetCanBecomeDedicatedProcess() {
+  can_become_dedicated_process_ = false;
+}
+
 void MockRenderProcessHost::FilterURL(bool empty_allowed, GURL* url) {
   RenderProcessHostImpl::FilterURL(this, empty_allowed, url);
 }
 
 #if BUILDFLAG(ENABLE_WEBRTC)
 void MockRenderProcessHost::EnableAudioDebugRecordings(
     const base::FilePath& file) {
 }
 
 void MockRenderProcessHost::DisableAudioDebugRecordings() {}
@@ skipping 64 matching lines @@
   for (auto it = processes_.begin(); it != processes_.end(); ++it) {
     if (it->get() == host) {
       it->release();
       processes_.erase(it);
       break;
     }
   }
 }
 
 }  // namespace content