Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Issue 2921053002: [Devtools] Removed "redirects" from NetworkRequest to use redirectSource (Closed)
Patch Set: Merge branch 'MOVE_NETWORK_STUFF_AROUND' into REMOVE_REDIRECTS_REBASE Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
index b27e2c5e98f59e8dbcbe0f6d33c76fc305d9b8fe..c6a3587ea25edc23cbdfe1500dc8b2b15d8d381f 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
@@ -636,16 +636,16 @@ SDK.NetworkDispatcher = class {
*/
_appendRedirect(requestId, time, redirectURL) {
var originalNetworkRequest = this._inflightRequestsById[requestId];
- var previousRedirects = originalNetworkRequest.redirects || [];
- originalNetworkRequest.setRequestId(requestId + ':redirected.' + previousRedirects.length);
- delete originalNetworkRequest.redirects;
- if (previousRedirects.length > 0)
- originalNetworkRequest.redirectSource = previousRedirects[previousRedirects.length - 1];
+ var redirectCount = 0;
+ for (var redirect = originalNetworkRequest.redirectSource(); redirect; redirect = redirect.redirectSource())
+ redirectCount++;
+
+ originalNetworkRequest.setRequestId(requestId + ':redirected.' + redirectCount);
this._finishNetworkRequest(originalNetworkRequest, time, -1);
var newNetworkRequest = this._createNetworkRequest(
requestId, originalNetworkRequest.frameId, originalNetworkRequest.loaderId, redirectURL,
originalNetworkRequest.documentURL, originalNetworkRequest.initiator());
- newNetworkRequest.redirects = previousRedirects.concat(originalNetworkRequest);
+ newNetworkRequest.setRedirectSource(originalNetworkRequest);
return newNetworkRequest;
}

Powered by Google App Engine
This is Rietveld 408576698