Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2921013003: Update a comment in proxy_resolution_service_provider_unittest.cc following deprecation of base::No… (Closed)

Created:
3 years, 6 months ago by gab
Modified:
3 years, 6 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update a comment in proxy_resolution_service_provider_unittest.cc following deprecation of base::NonThreadSafe. BUG=676387 Review-Url: https://codereview.chromium.org/2921013003 Cr-Commit-Position: refs/heads/master@{#476924} Committed: https://chromium.googlesource.com/chromium/src/+/60b3f18fedd0b2eb42a06d719cd121ecf7214c4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chromeos/dbus/services/proxy_resolution_service_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
gab
PTaL and CQ, thanks
3 years, 6 months ago (2017-06-02 19:00:34 UTC) #3
hashimoto
lgtm
3 years, 6 months ago (2017-06-05 02:18:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921013003/1
3 years, 6 months ago (2017-06-05 02:18:38 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 02:27:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/60b3f18fedd0b2eb42a06d719cd1...

Powered by Google App Engine
This is Rietveld 408576698