GN: Add an explicit gn arg for recovery in CFI

GN: Add an explicit gn arg for recovery in CFI

This will enable printing diagnostics on waterfall bots with recovery off.

Clusterfuzz builders require keeping recovery on.

BUG=726584
Review-Url: https://codereview.chromium.org/2920963002
Cr-Commit-Position: refs/heads/master@{#477948}
Committed: https://chromium.googlesource.com/chromium/src/+/8ad19ec2f37cc95d1ac660e7c605f1fb029e5dfc

[Michael Achenbach, 2017-06-02 07:52:33]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 07:52:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2017-06-02 07:54:37]

machenbach@chromium.org changed reviewers:
+ glider@chromium.org, jochen@chromium.org, pcc@chromium.org

[Michael Achenbach, 2017-06-02 07:54:38]

PTAL

[Michael Achenbach, 2017-06-02 07:55:08]

machenbach@chromium.org changed reviewers:
+ dpranke@chromium.org

[Michael Achenbach, 2017-06-02 07:55:09]

+dirk for mb change

[commit-bot: I haz the power, 2017-06-02 08:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 08:57:45]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-06-02 12:18:48]

I'm deferring to Dirk

[Michael Achenbach, 2017-06-07 08:21:16]

dpranke, pcc: Friendly ping. There was an email thread with more context about
this. Title: "Q: Why are we setting -fsanitize-recover=cfi in cfi_diag mode?"

[pcc1, 2017-06-07 18:23:37]

lgtm

Seems fine, but I'm not an owner, so I can't approve.

[Dirk Pranke, 2017-06-07 19:42:13]

lgtm, sorry for the delay.

https://codereview.chromium.org/2920963002/diff/20001/build/config/sanitizers...
File build/config/sanitizers/sanitizers.gni (right):

https://codereview.chromium.org/2920963002/diff/20001/build/config/sanitizers...
build/config/sanitizers/sanitizers.gni:75: use_cfi_recover = false
Should we have an assert somewhere that `!use_cfi_recover || use_cfi_diag` ?

[Michael Achenbach, 2017-06-07 20:59:33]

https://codereview.chromium.org/2920963002/diff/20001/build/config/sanitizers...
File build/config/sanitizers/sanitizers.gni (right):

https://codereview.chromium.org/2920963002/diff/20001/build/config/sanitizers...
build/config/sanitizers/sanitizers.gni:75: use_cfi_recover = false
On 2017/06/07 19:42:12, Dirk Pranke wrote:
> Should we have an assert somewhere that `!use_cfi_recover || use_cfi_diag` ?

Can add that tomorrow...

[Michael Achenbach, 2017-06-08 10:58:38]

https://codereview.chromium.org/2920963002/diff/20001/build/config/sanitizers...
File build/config/sanitizers/sanitizers.gni (right):

https://codereview.chromium.org/2920963002/diff/20001/build/config/sanitizers...
build/config/sanitizers/sanitizers.gni:75: use_cfi_recover = false
On 2017/06/07 20:59:32, machenbach (slow) wrote:
> On 2017/06/07 19:42:12, Dirk Pranke wrote:
> > Should we have an assert somewhere that `!use_cfi_recover || use_cfi_diag` ?
> 
> Can add that tomorrow...

Done in patch 3. Added it at the end of this file right after a bunch of other
similar asserts.

[Michael Achenbach, 2017-06-08 10:59:38]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2017-06-08 10:59:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, pcc@chromium.org
Link to the patchset: https://codereview.chromium.org/2920963002/#ps60001
(title: "typo")

[commit-bot: I haz the power, 2017-06-08 10:59:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 12:31:20]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496919578556690,
"parent_rev": "488ae5249bcea6c46af5e832f8be87dcc8df56e1", "commit_rev":
"8ad19ec2f37cc95d1ac660e7c605f1fb029e5dfc"}

[commit-bot: I haz the power, 2017-06-08 12:31:33]

Description was changed from

==========
GN: Add an explicit gn arg for recovery in CFI

This will enable printing diagnostics on waterfall bots with recovery off.

Clusterfuzz builders require keeping recovery on.

BUG=726584
==========

to

==========
GN: Add an explicit gn arg for recovery in CFI

This will enable printing diagnostics on waterfall bots with recovery off.

Clusterfuzz builders require keeping recovery on.

BUG=726584

Review-Url: https://codereview.chromium.org/2920963002
Cr-Commit-Position: refs/heads/master@{#477948}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ad19ec2f37cc95d1ac660e7c605...
==========

[commit-bot: I haz the power, 2017-06-08 12:31:39]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8ad19ec2f37cc95d1ac660e7c605...