Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2920863003: [ElementVisibilityObserver] Fix regression with default threshold (Closed)

Created:
3 years, 6 months ago by johnme
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[ElementVisibilityObserver] Fix regression with default threshold https://codereview.chromium.org/2830713003 (r468137, 913ee5fe4cfcc42ebc568965169258bc37fb0237) changed the default threshold of ElementVisibilityObserver from std::numeric_limits<float>::min() to zero, assuming that they would behave the same. It turns out that there's some confusion here - see https://github.com/WICG/IntersectionObserver/issues/164 - and for now we should continue to use std::numeric_limits<float>::min() to distinguish between completely hidden and partially visible. BUG=726839 Review-Url: https://codereview.chromium.org/2919543002 Cr-Original-Commit-Position: refs/heads/master@{#476265} Review-Url: https://codereview.chromium.org/2920863003 . Cr-Commit-Position: refs/branch-heads/3112@{#120} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/848e7b224a1b681fe3154f3b5f6fe2054d285c5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
johnme
3 years, 6 months ago (2017-06-02 17:03:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
848e7b224a1b681fe3154f3b5f6fe2054d285c5b.

Powered by Google App Engine
This is Rietveld 408576698