Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2920863002: Roll src/third_party/cros_system_api/ ff270ca21..d1586d3fc (1 commit) (Closed)

Created:
3 years, 6 months ago by Tim Song
Modified:
3 years, 6 months ago
Reviewers:
Miao, Daniel Erat
CC:
chromium-reviews, mcchou, ortuno
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/cros_system_api/ ff270ca21..d1586d3fc (1 commit) https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/ff270ca217a8..d1586d3fcb3a $ git log ff270ca21..d1586d3fc --date=short --no-merges --format='%ad %ae %s' 2017-05-25 tengs cros_system_api: Add constants for valid parameters of the SetLEConnectionParameters API. Created with: roll-dep src/third_party/cros_system_api BUG=725367 Review-Url: https://codereview.chromium.org/2920863002 Cr-Commit-Position: refs/heads/master@{#476519} Committed: https://chromium.googlesource.com/chromium/src/+/d9c939597cd5b8b2af091441674b526cd1cee52e

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
Tim Song
3 years, 6 months ago (2017-06-01 18:14:32 UTC) #2
Daniel Erat
lgtm
3 years, 6 months ago (2017-06-01 20:34:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920863002/1
3 years, 6 months ago (2017-06-01 20:38:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/352217)
3 years, 6 months ago (2017-06-01 20:59:42 UTC) #7
Miao
There is another patch which also uprevs cros_system_api, https://chromium-review.googlesource.com/c/517309/. You probably want to talk to ...
3 years, 6 months ago (2017-06-01 22:00:07 UTC) #9
Sonny Sasaka
On 2017/06/01 22:00:07, Miao wrote: > There is another patch which also uprevs cros_system_api, > ...
3 years, 6 months ago (2017-06-01 22:57:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920863002/20001
3 years, 6 months ago (2017-06-01 23:52:26 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 01:53:09 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d9c939597cd5b8b2af091441674b...

Powered by Google App Engine
This is Rietveld 408576698