ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm - Issue 2920853006: Removes usage of signin APIs that return scoped_nsobjects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm

Issue 2920853006: Removes usage of signin APIs that return scoped_nsobjects. (Closed)

Patch Set: Reparent Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | ios/chrome/browser/ui/authentication/signin_interaction_controller.mm » ('j') | ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm

diff --git a/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm b/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm

index cc10f5fcd6bd8759968941effe37dee293a9af84..6ff600bef5b6fa934f835b75161696e4c6833509 100644

--- a/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm

+++ b/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm

@@ -358,10 +358,10 @@ void HideButton(UIButton* button) {

- (void)openAuthenticationDialogAddIdentity {

DCHECK(!_interactionManager);

- _interactionManager =

+ _interactionManager.reset(

ios::GetChromeBrowserProvider()

->GetChromeIdentityService()

- ->NewChromeIdentityInteractionManager(_browserState, self);

+ ->CreateChromeIdentityInteractionManager(_browserState, self));

base::WeakNSObject<ChromeSigninViewController> weakSelf(self);

SigninCompletionCallback completion =

^(ChromeIdentity* identity, NSError* error) {