ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm - Issue 2920853006: Removes usage of signin APIs that return scoped_nsobjects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm

Issue 2920853006: Removes usage of signin APIs that return scoped_nsobjects. (Closed)

Patch Set: Reparent Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/authentication/signin_interaction_controller.mm ('k') | ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm

diff --git a/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm b/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm

index 0e38ee80c06753d2dcde6b58960c602978278294..ea44570f70575e2d5ec9a84327413b11c6472893 100644

--- a/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm

+++ b/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm

@@ -447,7 +447,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

UINavigationController* settingsDetails =

ios::GetChromeBrowserProvider()

->GetChromeIdentityService()

- ->NewWebAndAppSettingDetails(

+ ->CreateWebAndAppSettingDetailsController(

[self authService]->GetAuthenticatedIdentity(), self);

UIImage* closeIcon = [ChromeIcon closeIcon];

SEL action = @selector(closeGoogleActivitySettings:);

@@ -509,9 +509,10 @@ typedef NS_ENUM(NSInteger, ItemType) {

- (void)showAccountDetails:(ChromeIdentity*)identity {

if ([_alertCoordinator isVisible])

return;

- UIViewController* accountDetails = ios::GetChromeBrowserProvider()

- ->GetChromeIdentityService()

- ->NewAccountDetails(identity, self);

+ UIViewController* accountDetails =

msarda 2017/06/13 12:31:07 Just out of curiosity, was this leaking before?

stkhapugin 2017/06/15 12:28:43 Seems like it was :)

+ ios::GetChromeBrowserProvider()

+ ->GetChromeIdentityService()

+ ->CreateAccountDetailsController(identity, self);

if (!accountDetails) {

// Failed to create a new account details. Ignored.

return;