ios/public/provider/chrome/browser/signin/chrome_identity_service.h - Issue 2920853006: Removes usage of signin APIs that return scoped_nsobjects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/public/provider/chrome/browser/signin/chrome_identity_service.h

Issue 2920853006: Removes usage of signin APIs that return scoped_nsobjects. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm ('k') | ios/public/provider/chrome/browser/signin/chrome_identity_service.mm » ('j') | ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/public/provider/chrome/browser/signin/chrome_identity_service.h

diff --git a/ios/public/provider/chrome/browser/signin/chrome_identity_service.h b/ios/public/provider/chrome/browser/signin/chrome_identity_service.h

index fe675ce77dc3162a53823a9cbeda4498996f02e5..e99f53693c9380fb2e820801eaf111251b845452 100644

--- a/ios/public/provider/chrome/browser/signin/chrome_identity_service.h

+++ b/ios/public/provider/chrome/browser/signin/chrome_identity_service.h

@@ -102,19 +102,19 @@ class ChromeIdentityService {

// Returns a new account details controller to present. A cancel button is

// present as leading navigation item.

- virtual base::scoped_nsobject<UINavigationController> NewAccountDetails(

+ virtual UINavigationController* CreateAccountDetailsController(

msarda 2017/06/08 23:21:06 It is not clear to me how this changes will be rol

stkhapugin 2017/06/12 15:49:31 discussed offline, using 5 CLs

ChromeIdentity* identity,

id<ChromeIdentityBrowserOpener> browser_opener);

// Returns a new Web and App Setting Details controller to present.

- virtual base::scoped_nsobject<UINavigationController>

- NewWebAndAppSettingDetails(ChromeIdentity* identity,

- id<ChromeIdentityBrowserOpener> browser_opener);

+ virtual UINavigationController* CreateWebAndAppSettingDetailsController(

+ ChromeIdentity* identity,

+ id<ChromeIdentityBrowserOpener> browser_opener);

// Returns a new ChromeIdentityInteractionManager with |delegate| as its

// delegate.

- virtual base::scoped_nsobject<ChromeIdentityInteractionManager>

- NewChromeIdentityInteractionManager(

+ virtual ChromeIdentityInteractionManager*

+ CreateChromeIdentityInteractionManager(

ios::ChromeBrowserState* browser_state,

id<ChromeIdentityInteractionManagerDelegate> delegate) const;