Removes usage of signin APIs that return scoped_nsobjects.

ios/public/provider/chrome/browser/signin/chrome_identity_service.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_PUBLIC_PROVIDER_CHROME_BROWSER_SIGNIN_CHROME_IDENTITY_SERVICE_H_
 #define IOS_PUBLIC_PROVIDER_CHROME_BROWSER_SIGNIN_CHROME_IDENTITY_SERVICE_H_
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/mac/scoped_nsobject.h"

[msarda, 2017/06/08 23:21:06]

Remove this include.

[stkhapugin, 2017/06/12 15:49:31]

With 5 CLs required to land this cleanly, this will move to CL #5 that will
remove the old API and this include. 

 #include "base/macros.h"
 #include "base/observer_list.h"
 
 @class ChromeIdentity;
 @protocol ChromeIdentityBrowserOpener;
 @class ChromeIdentityInteractionManager;
 @protocol ChromeIdentityInteractionManagerDelegate;
 @class NSArray;
 @class NSDate;
 @class NSDictionary;
@@ skipping 72 matching lines @@
   // UIApplicationDelegate application:openURL:options:.
   virtual bool HandleApplicationOpenURL(UIApplication* application,
                                         NSURL* url,
                                         NSDictionary* options);
 
   // Dismisses all the dialogs created by the abstracted flows.
   virtual void DismissDialogs();
 
   // Returns a new account details controller to present. A cancel button is
   // present as leading navigation item.
-  virtual base::scoped_nsobject<UINavigationController> NewAccountDetails(
+  virtual UINavigationController* CreateAccountDetailsController(

[msarda, 2017/06/08 23:21:06]

It is not clear to me how this changes will be rolled by the downstream roller
(see comment on downstream CL as well).

[stkhapugin, 2017/06/12 15:49:31]

discussed offline, using 5 CLs 

       ChromeIdentity* identity,
       id<ChromeIdentityBrowserOpener> browser_opener);
 
   // Returns a new Web and App Setting Details controller to present.
-  virtual base::scoped_nsobject<UINavigationController>
-  NewWebAndAppSettingDetails(ChromeIdentity* identity,
-                             id<ChromeIdentityBrowserOpener> browser_opener);
+  virtual UINavigationController* CreateWebAndAppSettingDetailsController(
+      ChromeIdentity* identity,
+      id<ChromeIdentityBrowserOpener> browser_opener);
 
   // Returns a new ChromeIdentityInteractionManager with |delegate| as its
   // delegate.
-  virtual base::scoped_nsobject<ChromeIdentityInteractionManager>
-  NewChromeIdentityInteractionManager(
+  virtual ChromeIdentityInteractionManager*
+  CreateChromeIdentityInteractionManager(
       ios::ChromeBrowserState* browser_state,
       id<ChromeIdentityInteractionManagerDelegate> delegate) const;
 
   // Returns YES if |identity| is valid and if the service has it in its list of
   // identitites.
   virtual bool IsValidIdentity(ChromeIdentity* identity) const;
 
   // Returns the chrome identity having the email equal to |email| or |nil| if
   // no matching identity is found.
   virtual ChromeIdentity* GetIdentityWithEmail(const std::string& email) const;
@@ skipping 91 matching lines @@
 
  private:
   base::ObserverList<Observer, true> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeIdentityService);
 };
 
 }  // namespace ios
 
 #endif  // IOS_PUBLIC_PROVIDER_CHROME_BROWSER_SIGNIN_CHROME_IDENTITY_SERVICE_H_