chrome/browser/ui/views/profiles/profile_chooser_view.h - Issue 2920853004: [sync] Display an error when sync settings aren't confirmed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.h

Issue 2920853004: [sync] Display an error when sync settings aren't confirmed (Closed)

Patch Set: fix compile Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/profiles/profile_chooser_view.h

diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.h b/chrome/browser/ui/views/profiles/profile_chooser_view.h

index 72fcf29c44efd4b6374e69f8dca26ee40865a4cd..dc90bac5ad7b49ab6a8dc100c5f8ec3a5602d75a 100644

--- a/chrome/browser/ui/views/profiles/profile_chooser_view.h

+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.h

@@ -178,6 +178,7 @@ class ProfileChooserView : public content::WebContentsDelegate,

views::LabelButton* sync_error_upgrade_button_;

views::LabelButton* sync_error_signin_again_button_;

views::LabelButton* sync_error_signout_button_;

+ views::LabelButton* sync_error_settings_unconfirmed_button_;

sky 2017/06/07 20:25:04 Don't you need to initialize this to null?

Patrick Noland 2017/06/08 18:47:02 Good catch. It looks like this is done in ResetVie

// Links and buttons displayed in the active profile card.

views::Link* manage_accounts_link_;