[sync] Display an error when sync settings aren't confirmed

chrome/browser/ui/views/profiles/profile_chooser_view.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PROFILES_PROFILE_CHOOSER_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_PROFILES_PROFILE_CHOOSER_VIEW_H_
 
 #include <stddef.h>
 
 #include <map>
@@ skipping 160 matching lines @@
   // Buttons associated with the current profile.
   AccountButtonIndexes delete_account_button_map_;
   AccountButtonIndexes reauth_account_button_map_;
 
   // Buttons in the signin/sync error header on top of the desktop user menu.
   views::LabelButton* sync_error_signin_button_;
   views::LabelButton* sync_error_passphrase_button_;
   views::LabelButton* sync_error_upgrade_button_;
   views::LabelButton* sync_error_signin_again_button_;
   views::LabelButton* sync_error_signout_button_;
+  views::LabelButton* sync_error_settings_unconfirmed_button_;

[sky, 2017/06/07 20:25:04]

Don't you need to initialize this to null?

[Patrick Noland, 2017/06/08 18:47:02]

Good catch. It looks like this is done in ResetView, which is first called from
the constructor. Done.

 
   // Links and buttons displayed in the active profile card.
   views::Link* manage_accounts_link_;
   views::LabelButton* manage_accounts_button_;
   views::LabelButton* signin_current_profile_button_;
   views::LabelButton* auth_error_email_button_;
 
   // For material design user menu, the active profile card owns the profile
   // name and photo.
   views::LabelButton* current_profile_card_;
@@ skipping 28 matching lines @@
   // The GAIA service type provided in the response header.
   signin::GAIAServiceType gaia_service_type_;
 
   // The current access point of sign in.
   const signin_metrics::AccessPoint access_point_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileChooserView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PROFILES_PROFILE_CHOOSER_VIEW_H_