[sync] Display an error when sync settings aren't confirmed

chrome/browser/ui/avatar_button_error_controller.cc

Index: chrome/browser/ui/avatar_button_error_controller.cc
diff --git a/chrome/browser/ui/avatar_button_error_controller.cc b/chrome/browser/ui/avatar_button_error_controller.cc
index b4a0ff4562488cefe331beab416fbf29dc2e1999..161fc8ff0399fb216b5396389be064e357b2281d 100644
--- a/chrome/browser/ui/avatar_button_error_controller.cc
+++ b/chrome/browser/ui/avatar_button_error_controller.cc
@@ -94,7 +94,9 @@ bool AvatarButtonErrorController::SyncErrorObserver::HasSyncError() {
     sync_service->QueryDetailedSyncStatus(&status);
     return sync_service->HasUnrecoverableError() ||
            status.sync_protocol_error.action == syncer::UPGRADE_CLIENT ||
-           (sync_error_controller && sync_error_controller->HasError());
+           (sync_error_controller && sync_error_controller->HasError()) ||
+           (!sync_service->IsFirstSetupComplete() &&

[skym, 2017/06/01 19:48:44]

I've seen these two booleans checked before in this CL! Maybe the method in
sync_ui_util.cc should actually be in the PSS

[Patrick Noland, 2017/06/07 19:07:23]

Done.

+            sync_service->IsSyncRequested());
   }
   return false;
 }