[sync] Display an error when sync settings aren't confirmed

chrome/browser/ui/avatar_button_error_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/avatar_button_error_controller.h"
 
 #include "chrome/browser/profiles/profiles_state.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "components/browser_sync/profile_sync_service.h"
 #include "components/signin/core/browser/signin_error_controller.h"
@@ skipping 76 matching lines @@
 bool AvatarButtonErrorController::SyncErrorObserver::HasSyncError() {
   browser_sync::ProfileSyncService* sync_service =
       ProfileSyncServiceFactory::GetForProfile(profile_);
   if (sync_service) {
     SyncErrorController* sync_error_controller =
         sync_service->sync_error_controller();
     browser_sync::ProfileSyncService::Status status;
     sync_service->QueryDetailedSyncStatus(&status);
     return sync_service->HasUnrecoverableError() ||
            status.sync_protocol_error.action == syncer::UPGRADE_CLIENT ||
-           (sync_error_controller && sync_error_controller->HasError());
+           (sync_error_controller && sync_error_controller->HasError()) ||
+           (!sync_service->IsFirstSetupComplete() &&

[skym, 2017/06/01 19:48:44]

I've seen these two booleans checked before in this CL! Maybe the method in
sync_ui_util.cc should actually be in the PSS

[Patrick Noland, 2017/06/07 19:07:23]

Done.

+            sync_service->IsSyncRequested());
   }
   return false;
 }
 
 SyncErrorController* AvatarButtonErrorController::SyncErrorObserver::
     GetSyncErrorControllerIfNeeded() {
   browser_sync::ProfileSyncService* sync_service =
       ProfileSyncServiceFactory::GetForProfile(profile_);
   return sync_service ? sync_service->sync_error_controller() : nullptr;
 }