Improve DeviceSettingsService documentation

Improve DeviceSettingsService documentation

BUG=728656
Review-Url: https://codereview.chromium.org/2920833002
Cr-Commit-Position: refs/heads/master@{#476616}
Committed: https://chromium.googlesource.com/chromium/src/+/fedcbd35f0a601ed3e07642673a7ab0e602bee26

[Thiemo Nagel, 2017-06-01 16:12:11]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 16:12:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Thiemo Nagel, 2017-06-01 16:12:55]

tnagel@chromium.org changed reviewers:
+ emaxx@chromium.org

[Thiemo Nagel, 2017-06-01 16:12:56]

Hi Maksim,

could you please take a look?

Many thanks!
Thiemo

[commit-bot: I haz the power, 2017-06-01 16:44:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 16:44:26]

Dry run: This issue passed the CQ dry run.

[emaxx, 2017-06-01 20:13:31]

LGTM

https://codereview.chromium.org/2920833002/diff/1/chrome/browser/chromeos/set...
File chrome/browser/chromeos/settings/device_settings_service.h (right):

https://codereview.chromium.org/2920833002/diff/1/chrome/browser/chromeos/set...
chrome/browser/chromeos/settings/device_settings_service.h:128: // Returns the
status generated by the *last operation*.
nit: What about also renaming this method so that this peculiarity becomes
obvious? E.g. last_operation_status.

[Thiemo Nagel, 2017-06-02 11:25:39]

Thank you!

https://codereview.chromium.org/2920833002/diff/1/chrome/browser/chromeos/set...
File chrome/browser/chromeos/settings/device_settings_service.h (right):

https://codereview.chromium.org/2920833002/diff/1/chrome/browser/chromeos/set...
chrome/browser/chromeos/settings/device_settings_service.h:128: // Returns the
status generated by the *last operation*.
On 2017/06/01 20:13:31, emaxx wrote:
> nit: What about also renaming this method so that this peculiarity becomes
> obvious? E.g. last_operation_status.

I might do that in a follow-up CL.  Ideally, the observers should pass the
status so that the status() method can be removed completely.  I haven't looked
through the code enough to understand whether that would be feasible, though.

[Thiemo Nagel, 2017-06-02 11:25:44]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2017-06-02 11:26:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 11:29:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496402744992580, "parent_rev":
"335cbdf575424fa4c2ae627f8b2221df670f4a52", "commit_rev":
"fedcbd35f0a601ed3e07642673a7ab0e602bee26"}

[commit-bot: I haz the power, 2017-06-02 11:29:54]

Description was changed from

==========
Improve DeviceSettingsService documentation

BUG=728656
==========

to

==========
Improve DeviceSettingsService documentation

BUG=728656

Review-Url: https://codereview.chromium.org/2920833002
Cr-Commit-Position: refs/heads/master@{#476616}
Committed:
https://chromium.googlesource.com/chromium/src/+/fedcbd35f0a601ed3e07642673a7...
==========

[commit-bot: I haz the power, 2017-06-02 11:29:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fedcbd35f0a601ed3e07642673a7...