Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2920793002: Measure how often PSL and same-organization name credentials are suppressed. (Closed)

Created:
3 years, 6 months ago by engedy
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Measure how often PSL and same-organization name credentials are suppressed. To this end, the SuppressedHTTPSFormFetcher is extended into the SuppressedFormFetcher, which now fetches the two new kinds of suppressed credentials as well; and makes them available through the FormFetcher interface to PasswordFormManager, which ultimately records the histograms. BUG=720599 Review-Url: https://codereview.chromium.org/2912783002 Cr-Original-Commit-Position: refs/heads/master@{#475561} Review-Url: https://codereview.chromium.org/2920793002 . Cr-Commit-Position: refs/branch-heads/3112@{#86} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+819 lines, -673 lines) Patch
M components/password_manager/core/browser/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/fake_form_fetcher.h View 2 chunks +25 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/fake_form_fetcher.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/form_fetcher.h View 1 chunk +31 lines, -12 lines 0 comments Download
M components/password_manager/core/browser/form_fetcher_impl.h View 6 chunks +30 lines, -17 lines 0 comments Download
M components/password_manager/core/browser/form_fetcher_impl.cc View 7 chunks +86 lines, -26 lines 0 comments Download
M components/password_manager/core/browser/form_fetcher_impl_unittest.cc View 16 chunks +228 lines, -103 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.h View 2 chunks +23 lines, -15 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 3 chunks +56 lines, -21 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 4 chunks +237 lines, -170 lines 0 comments Download
A + components/password_manager/core/browser/suppressed_form_fetcher.h View 4 chunks +13 lines, -14 lines 0 comments Download
A components/password_manager/core/browser/suppressed_form_fetcher.cc View 1 chunk +41 lines, -0 lines 0 comments Download
A + components/password_manager/core/browser/suppressed_form_fetcher_unittest.cc View 6 chunks +26 lines, -24 lines 0 comments Download
D components/password_manager/core/browser/suppressed_https_form_fetcher.h View 1 chunk +0 lines, -63 lines 0 comments Download
D components/password_manager/core/browser/suppressed_https_form_fetcher.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D components/password_manager/core/browser/suppressed_https_form_fetcher_unittest.cc View 1 chunk +0 lines, -155 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
engedy
3 years, 6 months ago (2017-06-01 12:35:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c990cc2de3ac6475dab972b1baa6fd1f41c6f0d.

Powered by Google App Engine
This is Rietveld 408576698