Use entities as keys rather than IR nodes

Use entities as keys rather than IR nodes

- in field value computation
- in super constructor inlining

+ general reduction in astAdapter usage

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/fd3e76c4da5b415380cd5886a75474ae1cb626d4

[Johnni Winther, 2017-06-01 11:13:12]

Description was changed from

==========
Use entities as keys rather than IR nodes

- in field value computation
- in super constructor inlining
==========

to

==========
Use entities as keys rather than IR nodes

- in field value computation
- in super constructor inlining

+ general reduction in astAdapter usage
==========

[Johnni Winther, 2017-06-01 11:13:22]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-06-01 22:08:48]

https://codereview.chromium.org/2920753002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map.dart (right):

https://codereview.chromium.org/2920753002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map.dart:162: void
enterInlinedMember(MemberEntity member);
mmm. Maybe you have more in mind behind this, but it seems odd to me to add this
on this interface. I had the impression this interface was pretty much
stateless.

In this case, it feels like this inlining stack is mainly used for the ssa
builder, so I'd be inclined to keep it contained there.

https://codereview.chromium.org/2920753002/diff/1/pkg/compiler/lib/src/ssa/ke...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2920753002/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:37: class KernelAstAdapter
extends KernelToElementMapMixin {
one possiblity here is to subdivide this class in 2:
 - the implementation of kerneltoElementMap
 - anything that is only needed for ssa building (like the current element
stack)

[Siggi Cherem (dart-lang), 2017-06-01 22:15:39]

lgtm

https://codereview.chromium.org/2920753002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map.dart (right):

https://codereview.chromium.org/2920753002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map.dart:162: void
enterInlinedMember(MemberEntity member);
On 2017/06/01 22:08:47, Siggi Cherem (dart-lang) wrote:
> mmm. Maybe you have more in mind behind this, but it seems odd to me to add
this
> on this interface. I had the impression this interface was pretty much
> stateless.
> 
> In this case, it feels like this inlining stack is mainly used for the ssa
> builder, so I'd be inclined to keep it contained there.

ha - just saw the next CL, seems like we are in agreement here.

If it is easy to remove it from this API and only keep it in the ast adapter,
then that might be a cleaner intermediate thing to land

[Johnni Winther, 2017-06-02 09:25:04]

https://codereview.chromium.org/2920753002/diff/1/pkg/compiler/lib/src/ssa/ke...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2920753002/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:37: class KernelAstAdapter
extends KernelToElementMapMixin {
On 2017/06/01 22:08:48, Siggi Cherem (dart-lang) wrote:
> one possiblity here is to subdivide this class in 2:
>  - the implementation of kerneltoElementMap
>  - anything that is only needed for ssa building (like the current element
> stack)

They are tied together through TreeElements!

[Johnni Winther, 2017-06-02 09:37:22]

Description was changed from

==========
Use entities as keys rather than IR nodes

- in field value computation
- in super constructor inlining

+ general reduction in astAdapter usage
==========

to

==========
Use entities as keys rather than IR nodes

- in field value computation
- in super constructor inlining

+ general reduction in astAdapter usage

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fd3e76c4da5b415380cd5886a75474ae1cb626d4
==========

[Johnni Winther, 2017-06-02 09:37:23]

Committed patchset #1 (id:1) manually as
fd3e76c4da5b415380cd5886a75474ae1cb626d4 (presubmit successful).