Use entities as keys rather than IR nodes

pkg/compiler/lib/src/kernel/element_map.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:kernel/ast.dart' as ir;
 
 import '../common.dart';
 import '../common/names.dart';
 import '../constants/constructors.dart';
 import '../constants/expressions.dart';
@@ skipping 137 matching lines @@
   /// Computes the [ConstantValue] for the constant [expression].
   ConstantValue getConstantValue(ir.Expression expression);
 
   /// Returns the `noSuchMethod` [FunctionEntity] call from a
   /// `super.noSuchMethod` invocation within [cls].
   FunctionEntity getSuperNoSuchMethod(ClassEntity cls);
 
   /// Returns a [Spannable] for a message pointing to the IR [node] in the
   /// context of [member].
   Spannable getSpannable(MemberEntity member, ir.Node node);
+
+  // TODO(johnniwinther): Move these to a `KernelToLocalsMap`, maybe even make
+  // the return the `KernelToLocalsMap` to use from now on.
+  /// Call to notify that [member] is currently being inlined.
+  void enterInlinedMember(MemberEntity member);

[Siggi Cherem (dart-lang), 2017/06/01 22:08:47]

mmm. Maybe you have more in mind behind this, but it seems odd to me to add this
on this interface. I had the impression this interface was pretty much
stateless.

In this case, it feels like this inlining stack is mainly used for the ssa
builder, so I'd be inclined to keep it contained there.

[Siggi Cherem (dart-lang), 2017/06/01 22:15:39]

ha - just saw the next CL, seems like we are in agreement here.

If it is easy to remove it from this API and only keep it in the ast adapter,
then that might be a cleaner intermediate thing to land

+
+  /// Call to notify that [member] is no longer being inlined.
+  void leaveInlinedMember(MemberEntity member);
 }
 
 /// Kinds of foreign functions.
 enum ForeignKind {
   JS,
   JS_BUILTIN,
   JS_EMBEDDED_GLOBAL,
   JS_INTERCEPTOR_CONSTANT,
   NONE,
 }
@@ skipping 334 matching lines @@
         // `Object.superNoSuchMethod`.
         break;
       }
     }
     FunctionEntity function = elementEnvironment.lookupClassMember(
         commonElements.objectClass, Identifiers.noSuchMethod_);
     assert(invariant(cls, function != null,
         message: "No super noSuchMethod found for class $cls."));
     return function;
   }
+
+  @override
+  void enterInlinedMember(MemberEntity member) {}
+
+  @override
+  void leaveInlinedMember(MemberEntity member) {}
 }
 
 /// Visitor that converts string literals and concatenations of string literals
 /// into the string value.
 class Stringifier extends ir.ExpressionVisitor<String> {
   @override
   String visitStringLiteral(ir.StringLiteral node) => node.value;
 
   @override
   String visitStringConcatenation(ir.StringConcatenation node) {
@@ skipping 391 matching lines @@
   TypeMask typeOfIteratorCurrent(ir.ForInStatement forInStatement);
 
   /// Returns the inferred type of `moveNext` in [forInStatement].
   TypeMask typeOfIteratorMoveNext(ir.ForInStatement forInStatement);
 
   /// Returns `true` if [forInStatement] is inferred to be a JavaScript
   /// indexable iterator.
   bool isJsIndexableIterator(
       ir.ForInStatement forInStatement, ClosedWorld closedWorld);
 
+  /// Returns `true` if [mask] is inferred to have a JavaScript `length`
+  /// property.
+  bool isFixedLength(TypeMask mask, ClosedWorld closedWorld);
+
   /// Returns the inferred index type of [forInStatement].
   TypeMask inferredIndexType(ir.ForInStatement forInStatement);
 
   /// Returns the inferred type of [member].
   TypeMask getInferredTypeOf(MemberEntity member);
 
   /// Returns the inferred type of a dynamic [selector] access on a receiver of
   /// type [mask].
   TypeMask selectorTypeOf(Selector selector, TypeMask mask);
 
   /// Returns the returned type annotation in the [nativeBehavior].
   TypeMask typeFromNativeBehavior(
       native.NativeBehavior nativeBehavior, ClosedWorld closedWorld);
 }