|
|
DescriptionUse ContainsValue() instead of std::find() in chromecast/
BUG=561800
Review-Url: https://codereview.chromium.org/2920723002
Cr-Commit-Position: refs/heads/master@{#476931}
Committed: https://chromium.googlesource.com/chromium/src/+/a7ee6cb0800d2e560eeb4b912c6d8f21ef1987ae
Patch Set 1 #Patch Set 2 : Changed ContainsValue() -> base::ContainsValue() #
Total comments: 2
Patch Set 3 : Adding "base/stl_util.h" after "cast_focus_client_aura.h" #
Total comments: 4
Patch Set 4 : Adding blank line and removing an extra line. #
Messages
Total messages: 37 (20 generated)
Description was changed from ========== Use ContainsValue() instead of std::find() in chromecast/ BUG=561800 ========== to ========== Use ContainsValue() instead of std::find() in chromecast/ BUG=561800 ==========
tripta.g@samsung.com changed reviewers: + a.suchit@samsung.com
Please review the code changes.
The CQ bit was checked by tripta.g@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by tripta.g@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by tripta.g@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
tripta.g@samsung.com changed reviewers: + alokp@chromium.org, dalecurtis@chromium.org, sky@chromium.org
Please review code changes.
sky@chromium.org changed reviewers: - sky@chromium.org
When adding more than one reviewer please indicate who you expect to review what. Also, it looks like you have local OWNERs here and don't need me, so I'm removing myself.
https://codereview.chromium.org/2920723002/diff/20001/chromecast/graphics/cas... File chromecast/graphics/cast_focus_client_aura.cc (right): https://codereview.chromium.org/2920723002/diff/20001/chromecast/graphics/cas... chromecast/graphics/cast_focus_client_aura.cc:5: #include "base/stl_util.h" base/stl_util.h should be included after cast_focus_client_aura.h
Have added base/stl_util.h after cast_focus_client_aura.h https://codereview.chromium.org/2920723002/diff/20001/chromecast/graphics/cas... File chromecast/graphics/cast_focus_client_aura.cc (right): https://codereview.chromium.org/2920723002/diff/20001/chromecast/graphics/cas... chromecast/graphics/cast_focus_client_aura.cc:5: #include "base/stl_util.h" On 2017/06/01 19:01:21, alokp wrote: > base/stl_util.h should be included after cast_focus_client_aura.h Have made the changes.
please run git-cl format before uploading the patch. https://codereview.chromium.org/2920723002/diff/40001/chromecast/graphics/cas... File chromecast/graphics/cast_focus_client_aura.cc (right): https://codereview.chromium.org/2920723002/diff/40001/chromecast/graphics/cas... chromecast/graphics/cast_focus_client_aura.cc:6: #include "base/stl_util.h" add a line here. https://codereview.chromium.org/2920723002/diff/40001/chromecast/graphics/cas... chromecast/graphics/cast_focus_client_aura.cc:7: remove this line
Patchset #4 (id:60001) has been deleted
Have made the changes and have run "git cl format" this time. https://codereview.chromium.org/2920723002/diff/40001/chromecast/graphics/cas... File chromecast/graphics/cast_focus_client_aura.cc (right): https://codereview.chromium.org/2920723002/diff/40001/chromecast/graphics/cas... chromecast/graphics/cast_focus_client_aura.cc:6: #include "base/stl_util.h" On 2017/06/02 04:59:35, alokp wrote: > add a line here. Have made the changes. Please check. https://codereview.chromium.org/2920723002/diff/40001/chromecast/graphics/cas... chromecast/graphics/cast_focus_client_aura.cc:7: On 2017/06/02 04:59:35, alokp wrote: > remove this line Have made the changes. Please check.
Patchset #4 (id:80001) has been deleted
Some issue with my git. The patch is uploaded now.
dalecurtis@chromium.org changed reviewers: - dalecurtis@chromium.org
lgtm
The CQ bit was checked by a.suchit@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496631312411920, "parent_rev": "3300fca96e914bae525ab150e35eb946a5292821", "commit_rev": "a7ee6cb0800d2e560eeb4b912c6d8f21ef1987ae"}
Message was sent while issue was closed.
Description was changed from ========== Use ContainsValue() instead of std::find() in chromecast/ BUG=561800 ========== to ========== Use ContainsValue() instead of std::find() in chromecast/ BUG=561800 Review-Url: https://codereview.chromium.org/2920723002 Cr-Commit-Position: refs/heads/master@{#476931} Committed: https://chromium.googlesource.com/chromium/src/+/a7ee6cb0800d2e560eeb4b912c6d... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as https://chromium.googlesource.com/chromium/src/+/a7ee6cb0800d2e560eeb4b912c6d... |