Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Issue 2920723002: Use ContainsValue() instead of std::find() in chromecast/ (Closed)

Created:
3 years, 6 months ago by Tripta
Modified:
3 years, 6 months ago
Reviewers:
a.suchit2, a.suchit, alokp
CC:
alokp+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, lcwu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ContainsValue() instead of std::find() in chromecast/ BUG=561800 Review-Url: https://codereview.chromium.org/2920723002 Cr-Commit-Position: refs/heads/master@{#476931} Committed: https://chromium.googlesource.com/chromium/src/+/a7ee6cb0800d2e560eeb4b912c6d8f21ef1987ae

Patch Set 1 #

Patch Set 2 : Changed ContainsValue() -> base::ContainsValue() #

Total comments: 2

Patch Set 3 : Adding "base/stl_util.h" after "cast_focus_client_aura.h" #

Total comments: 4

Patch Set 4 : Adding blank line and removing an extra line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M chromecast/base/observer.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chromecast/graphics/cast_focus_client_aura.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M chromecast/media/audio/cast_audio_mixer.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 37 (20 generated)
Tripta
Please review the code changes.
3 years, 6 months ago (2017-06-01 07:56:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920723002/1
3 years, 6 months ago (2017-06-01 07:57:15 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-01 07:57:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920723002/20001
3 years, 6 months ago (2017-06-01 10:43:44 UTC) #13
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-01 10:43:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920723002/20001
3 years, 6 months ago (2017-06-01 11:54:40 UTC) #17
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-01 11:54:41 UTC) #19
Tripta
Please review code changes.
3 years, 6 months ago (2017-06-01 12:03:58 UTC) #21
sky
When adding more than one reviewer please indicate who you expect to review what. Also, ...
3 years, 6 months ago (2017-06-01 18:55:22 UTC) #23
alokp
https://codereview.chromium.org/2920723002/diff/20001/chromecast/graphics/cast_focus_client_aura.cc File chromecast/graphics/cast_focus_client_aura.cc (right): https://codereview.chromium.org/2920723002/diff/20001/chromecast/graphics/cast_focus_client_aura.cc#newcode5 chromecast/graphics/cast_focus_client_aura.cc:5: #include "base/stl_util.h" base/stl_util.h should be included after cast_focus_client_aura.h
3 years, 6 months ago (2017-06-01 19:01:21 UTC) #24
Tripta
Have added base/stl_util.h after cast_focus_client_aura.h https://codereview.chromium.org/2920723002/diff/20001/chromecast/graphics/cast_focus_client_aura.cc File chromecast/graphics/cast_focus_client_aura.cc (right): https://codereview.chromium.org/2920723002/diff/20001/chromecast/graphics/cast_focus_client_aura.cc#newcode5 chromecast/graphics/cast_focus_client_aura.cc:5: #include "base/stl_util.h" On 2017/06/01 ...
3 years, 6 months ago (2017-06-02 04:40:22 UTC) #25
alokp
please run git-cl format before uploading the patch. https://codereview.chromium.org/2920723002/diff/40001/chromecast/graphics/cast_focus_client_aura.cc File chromecast/graphics/cast_focus_client_aura.cc (right): https://codereview.chromium.org/2920723002/diff/40001/chromecast/graphics/cast_focus_client_aura.cc#newcode6 chromecast/graphics/cast_focus_client_aura.cc:6: #include ...
3 years, 6 months ago (2017-06-02 04:59:35 UTC) #26
Tripta
Have made the changes and have run "git cl format" this time. https://codereview.chromium.org/2920723002/diff/40001/chromecast/graphics/cast_focus_client_aura.cc File chromecast/graphics/cast_focus_client_aura.cc ...
3 years, 6 months ago (2017-06-02 08:08:02 UTC) #28
Tripta
Some issue with my git. The patch is uploaded now.
3 years, 6 months ago (2017-06-02 09:48:54 UTC) #30
alokp
lgtm
3 years, 6 months ago (2017-06-03 04:03:48 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920723002/100001
3 years, 6 months ago (2017-06-05 02:55:21 UTC) #34
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 03:10:14 UTC) #37
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/a7ee6cb0800d2e560eeb4b912c6d...

Powered by Google App Engine
This is Rietveld 408576698