Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2920703003: Sets the rotation source as USER when using the system display API (Closed)

Created:
3 years, 6 months ago by malaykeshav
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Sets the rotation source as USER when using the system display API The rotation preference is not persistent across reboot since we only store the preference if the rotation source is 'USER'. With the move to MD settings, we now use the System Display API to update any display settings, which still uses the source of rotation as ACTIVE. This change updates the source of rotation to USER. We persist the setting even if the change has been made by an application. (This is consistent with the other settings that are being set via this API.) BUG=716110 COMPONENT=Display Info Provider, Chrome Settings Review-Url: https://codereview.chromium.org/2920703003 Cr-Commit-Position: refs/heads/master@{#476734} Committed: https://chromium.googlesource.com/chromium/src/+/100ef2b48dbab733c8cebe556a673f4f16d20c49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/display_info_provider_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
malaykeshav
PTAL
3 years, 6 months ago (2017-06-01 17:21:15 UTC) #5
oshima
lgtm
3 years, 6 months ago (2017-06-02 16:14:17 UTC) #8
malaykeshav
+rockot@ for OWNERS approval
3 years, 6 months ago (2017-06-02 17:15:11 UTC) #10
Ken Rockot(use gerrit already)
lgtm
3 years, 6 months ago (2017-06-02 17:32:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920703003/1
3 years, 6 months ago (2017-06-02 17:38:54 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 18:43:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/100ef2b48dbab733c8cebe556a67...

Powered by Google App Engine
This is Rietveld 408576698