Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2920703002: increase bucket size and break down video by http/https Effected existing histograms: Net.HttpConte… (Closed)

Created:
3 years, 6 months ago by tbansal1
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

increase bucket size and break down video by http/https Effected existing histograms: Net.HttpContentLength.Http Net.HttpContentLength.Https Net.HttpContentLength.Video Net.HttpContentLength.Http.Video Net.HttpContentLength.Https.Video New Histograms: Net.HttpContentLength.Http.Direct Net.HttpContentLength.Http.ViaDRP Net.HttpContentLength.Http.BypassedDRP Net.HttpContentLength.Http.Other Net.HttpContentLength.Https.Direct Net.HttpContentLength.Https.ViaDRP Net.HttpContentLength.Https.BypassedDRP Net.HttpContentLength.Https.Other Net.HttpContentLength.Http.Direct.Video Net.HttpContentLength.Http.ViaDRP.Video Net.HttpContentLength.Http.BypassedDRP.Video Net.HttpContentLength.Http.Other.Video Net.HttpContentLength.Https.Direct.Video Net.HttpContentLength.Https.ViaDRP.Video Net.HttpContentLength.Https.BypassedDRP.Video Net.HttpContentLength.Https.Other.Video BUG=689659 Review-Url: https://codereview.chromium.org/2888653003 Cr-Original-Commit-Position: refs/heads/master@{#474922} Review-Url: https://codereview.chromium.org/2920703002 . Cr-Commit-Position: refs/branch-heads/3112@{#82} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/d63765809ea46b7f59a1f56a9719634d5fbf4864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -38 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc View 5 chunks +64 lines, -22 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc View 4 chunks +81 lines, -13 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +42 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tbansal1
3 years, 6 months ago (2017-06-01 06:52:04 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d63765809ea46b7f59a1f56a9719634d5fbf4864.

Powered by Google App Engine
This is Rietveld 408576698