Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2920613003: Clean up unused grit header includes in ash/. (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, sadrul, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up unused grit header includes in ash/. Review-Url: https://codereview.chromium.org/2920613003 Cr-Commit-Position: refs/heads/master@{#476366} Committed: https://chromium.googlesource.com/chromium/src/+/0845bbdb7787e07db037721abe80ca22bb1bc4cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_size_button_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/bluetooth/tray_bluetooth.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/brightness/tray_brightness.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/ime_menu/ime_list_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/ime_menu/ime_menu_tray.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/palette/common_palette_tool.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/palette/palette_tray.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/session/tray_session_length_limit.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/hover_highlight_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/system/tray/label_tray_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/tray_details_view_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray_accessibility.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray_caps_lock.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/user/user_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/overview/window_selector_item.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
Created with assistance from tools/resources/list_unused_grit_header.py.
3 years, 6 months ago (2017-06-01 00:05:23 UTC) #6
oshima
lgtm
3 years, 6 months ago (2017-06-01 15:56:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920613003/1
3 years, 6 months ago (2017-06-01 18:35:20 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 18:40:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0845bbdb7787e07db037721abe80...

Powered by Google App Engine
This is Rietveld 408576698