Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2920573002: Force off clang for GPU FYI release bots. (Closed)

Created:
3 years, 6 months ago by Nico
Modified:
3 years, 6 months ago
Reviewers:
Jamie Madill
CC:
chromium-reviews, hans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Force off clang for GPU FYI release bots. The GPU FYI release bots went red when we switched on clang by default. It doesn't sound like that'll be fixed soon, so let's explicitly disable clang on these FYI bots so that they're not affected the next time we turn it on by default. BUG=727437 Review-Url: https://codereview.chromium.org/2920573002 Cr-Commit-Position: refs/heads/master@{#476048} Committed: https://chromium.googlesource.com/chromium/src/+/4f307f2f73c304ee22ac9fb43d3ce4fbf493ae4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Nico
3 years, 6 months ago (2017-05-31 19:23:25 UTC) #2
Jamie Madill
not lgtm, this is just going to make us break clang more often.
3 years, 6 months ago (2017-05-31 19:40:54 UTC) #5
hans
On 2017/05/31 19:40:54, Jamie Madill wrote: > not lgtm, this is just going to make ...
3 years, 6 months ago (2017-05-31 19:44:53 UTC) #6
Nico
Hm? These two bots currently turn red 100% reliably if clang is turned on, so ...
3 years, 6 months ago (2017-05-31 19:45:01 UTC) #7
Jamie Madill
sure, lgtm then, if this doesn't regress coverage.
3 years, 6 months ago (2017-05-31 19:48:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920573002/1
3 years, 6 months ago (2017-05-31 19:49:52 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 21:52:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f307f2f73c304ee22ac9fb43d3c...

Powered by Google App Engine
This is Rietveld 408576698